Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strict memory management using EigWork struct for lax::Eig_ #333

Merged
merged 10 commits into from Sep 24, 2022

Conversation

termoshtt
Copy link
Member

@termoshtt termoshtt commented Sep 8, 2022

Revival of #241, for #168

  • This PR only adds new API without changing existing ones

New API

  • lax::eig::EigWork for managing working memory
  • lax::eig::EigOwned and lax::eig::EigRef for its result
  • VecAssumeInit::slice_assume_init_ref

@termoshtt termoshtt self-assigned this Sep 8, 2022
@codecov
Copy link

codecov bot commented Sep 8, 2022

Codecov Report

Merging #333 (96a83e6) into master (3a8520c) will increase coverage by 0.14%.
The diff coverage is 98.70%.

@@            Coverage Diff             @@
##           master     #333      +/-   ##
==========================================
+ Coverage   90.01%   90.15%   +0.14%     
==========================================
  Files          72       72              
  Lines        4026     4105      +79     
==========================================
+ Hits         3624     3701      +77     
- Misses        402      404       +2     
Impacted Files Coverage Δ
lax/src/alloc.rs 80.00% <60.00%> (-10.91%) ⬇️
lax/src/eig.rs 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@termoshtt termoshtt mentioned this pull request Sep 8, 2022
@termoshtt termoshtt force-pushed the lax-strict-memory-management branch 6 times, most recently from 5f00eff to 184de06 Compare September 21, 2022 06:07
@termoshtt termoshtt force-pushed the lax-strict-memory-management branch 5 times, most recently from 9126810 to dab63ed Compare September 23, 2022 09:13
@termoshtt termoshtt force-pushed the lax-strict-memory-management branch 5 times, most recently from 07dd23a to ede3cd9 Compare September 23, 2022 14:59
@termoshtt termoshtt changed the title Strict memory management in lax Strict memory management for lax::Eig_ Sep 24, 2022
@termoshtt termoshtt marked this pull request as ready for review September 24, 2022 08:31
@termoshtt termoshtt merged commit e407602 into master Sep 24, 2022
@termoshtt termoshtt deleted the lax-strict-memory-management branch September 24, 2022 08:48
@termoshtt termoshtt changed the title Strict memory management for lax::Eig_ Strict memory management fusing EigWork struct for lax::Eig_ Oct 3, 2022
@termoshtt termoshtt changed the title Strict memory management fusing EigWork struct for lax::Eig_ Strict memory management using EigWork struct for lax::Eig_ Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant