Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MaybeUninit<T> for uninitialized memory #329

Merged
merged 10 commits into from Sep 1, 2022
Merged

MaybeUninit<T> for uninitialized memory #329

merged 10 commits into from Sep 1, 2022

Conversation

termoshtt
Copy link
Member

Resolve #327

@termoshtt termoshtt self-assigned this Aug 31, 2022
@codecov
Copy link

codecov bot commented Aug 31, 2022

Codecov Report

Merging #329 (b5b92e3) into master (791713f) will decrease coverage by 0.08%.
The diff coverage is 93.75%.

@@            Coverage Diff             @@
##           master     #329      +/-   ##
==========================================
- Coverage   90.06%   89.97%   -0.09%     
==========================================
  Files          71       71              
  Lines        3864     3911      +47     
==========================================
+ Hits         3480     3519      +39     
- Misses        384      392       +8     
Impacted Files Coverage Δ
lax/src/layout.rs 81.15% <76.19%> (-9.23%) ⬇️
lax/src/solveh.rs 75.51% <80.00%> (+0.51%) ⬆️
lax/src/eigh.rs 95.00% <87.50%> (+0.17%) ⬆️
lax/src/eig.rs 100.00% <100.00%> (ø)
lax/src/least_squares.rs 100.00% <100.00%> (ø)
lax/src/lib.rs 96.87% <100.00%> (+0.32%) ⬆️
lax/src/opnorm.rs 100.00% <100.00%> (ø)
lax/src/qr.rs 100.00% <100.00%> (ø)
lax/src/rcond.rs 100.00% <100.00%> (ø)
lax/src/solve.rs 100.00% <100.00%> (ø)
... and 5 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@termoshtt termoshtt force-pushed the maybe-uninit branch 2 times, most recently from ef3c5a1 to e7e8275 Compare August 31, 2022 13:51
@termoshtt termoshtt marked this pull request as ready for review September 1, 2022 07:06
@termoshtt
Copy link
Member Author

clippy job now passed 🎉

@termoshtt termoshtt merged commit ea5c96b into master Sep 1, 2022
@termoshtt termoshtt deleted the maybe-uninit branch September 1, 2022 07:09
@termoshtt termoshtt added the bug Bug issue, or bug fix change label Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug issue, or bug fix change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uninitialized memory management in lax crate
1 participant