Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use intel-mkl-system feature to calc coverage #322

Merged
merged 1 commit into from Aug 30, 2022

Conversation

termoshtt
Copy link
Member

@termoshtt termoshtt commented Aug 28, 2022

Use new container -> #323

Coverage job on master fails with link error
https://github.com/rust-ndarray/ndarray-linalg/runs/8094527572?check_suite_focus=true

This occurs with intel-mkl-static feature. This PR tries to use intel-mkl-system feature instead.

@termoshtt termoshtt self-assigned this Aug 28, 2022
@termoshtt termoshtt changed the title Upgrade contaier for evaluating code coverage Fix code coverage job Aug 28, 2022
@termoshtt termoshtt marked this pull request as draft August 28, 2022 13:16
@termoshtt
Copy link
Member Author

Container update is done in #323. This PR try to fix coverage job

@codecov
Copy link

codecov bot commented Aug 30, 2022

Codecov Report

Merging #322 (3c184eb) into master (55866d9) will decrease coverage by 0.80%.
The diff coverage is 77.77%.

@@            Coverage Diff             @@
##           master     #322      +/-   ##
==========================================
- Coverage   90.71%   89.90%   -0.81%     
==========================================
  Files          71       71              
  Lines        3726     3756      +30     
==========================================
- Hits         3380     3377       -3     
- Misses        346      379      +33     
Impacted Files Coverage Δ
lax/src/error.rs 83.33% <ø> (ø)
lax/src/tridiagonal.rs 78.02% <ø> (+0.84%) ⬆️
ndarray-linalg/src/svddc.rs 90.47% <ø> (ø)
ndarray-linalg/src/tridiagonal.rs 38.85% <20.00%> (+5.20%) ⬆️
ndarray-linalg/src/krylov/householder.rs 73.40% <100.00%> (ø)
ndarray-linalg/src/krylov/mgs.rs 91.89% <100.00%> (ø)
ndarray-linalg/src/layout.rs 90.62% <100.00%> (+5.33%) ⬆️
ndarray-linalg/src/least_squares.rs 96.15% <100.00%> (-2.72%) ⬇️
ndarray-linalg/src/lobpcg/lobpcg.rs 90.45% <100.00%> (-1.67%) ⬇️
ndarray-linalg/src/lobpcg/svd.rs 87.50% <100.00%> (+2.13%) ⬆️
... and 29 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@termoshtt termoshtt changed the title Fix code coverage job Use intel-mkl-system feature to calc coverage Aug 30, 2022
@termoshtt termoshtt marked this pull request as ready for review August 30, 2022 15:32
@termoshtt termoshtt merged commit 0cfde73 into master Aug 30, 2022
@termoshtt termoshtt deleted the update-coverage-container branch August 30, 2022 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant