Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LoongArch group #985

Merged
merged 1 commit into from Jun 12, 2023
Merged

Add LoongArch group #985

merged 1 commit into from Jun 12, 2023

Conversation

heiher
Copy link
Contributor

@heiher heiher commented Apr 24, 2023

I would like to request the creation of a LoongArch group after the initial support for LoongArch is merged. We are currently preparing to promote the loongarch64-unknown-linux-gnu target to tier 2, and I believe that creating a group at this time would be helpful to the community.

r? @pietroalbini @rylev

@rylev
Copy link
Member

rylev commented May 10, 2023

r? @wesleywiser

Even though this is a marker team and not a subteam, I'd still like some additional approval before merging.

wesleywiser
wesleywiser previously approved these changes May 10, 2023
Copy link
Member

@wesleywiser wesleywiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me to have a notification group. Thanks for setting this up!

I think it would probably also make sense to reach out to other folks who participated in the target bring up to see if they are interested in being on the group as well (eg @zhaixiaojuan, @xen0n, others?)

@xen0n
Copy link

xen0n commented May 10, 2023

Thanks for putting together the PR and bringing up everything else!

I'm personally willing to help: me being unaffiliated & having experience in LoongArch and Rust porting would probably help. I can also help with Linux and/or LLVM should any problem arise.

Also maybe @xry111 would be interested in getting the heads-ups too, so cc-ing him ;-)

@heiher
Copy link
Contributor Author

heiher commented May 12, 2023

Thanks for your contributions and helps.

@xry111
Copy link

xry111 commented May 12, 2023

Should we list @zhaixiaojuan as well?

@heiher
Copy link
Contributor Author

heiher commented May 12, 2023

Thank you for bringing that to my attention. Due to recent personnel changes, @zhaixiaojuan is no longer involved in the Rust/LoongArch project. To ensure that we do not cause any disruptions or inconveniences for her, we have not listed her name.

Also, would you be interested in this? @xry111 I believe that collaborations are welcome.

name = 'WANG Xuerui'
github = 'xen0n'
github-id = 1175567
email = 'git@xen0n.name'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My Zulip ID is 507183, you may want to put this in too.

@xry111
Copy link

xry111 commented May 12, 2023

Thank you for bringing that to my attention. Due to recent personnel changes, @zhaixiaojuan is no longer involved in the Rust/LoongArch project. To ensure that we do not cause any disruptions or inconveniences for her, we have not listed her name.

Also, would you be interested in this? @xry111 I believe that collaborations are welcome.

My info:

name = 'Xi Ruoyao'
github = 'xry111'
github-id = 8733039
email = 'xry111@xry111.site'

I'm not a Rust (internal) expert but I can write simple Rust programs, and I guess I can help integrating Rustc with distros, troubleshooting downstream issues, etc.

@heiher
Copy link
Contributor Author

heiher commented May 12, 2023

Amended. Thank you!

@heiher heiher requested a review from wesleywiser May 22, 2023 03:06
@heiher
Copy link
Contributor Author

heiher commented May 25, 2023

@rylev Ready. Thank you.

@xen0n
Copy link

xen0n commented Jun 5, 2023

A gentle ping.

The target has been in for a while, and it would benefit everyone if the porters could be notified / pinged / mentioned whenever bugs or questions arise regarding the LoongArch port.

@rylev rylev merged commit c41eb04 into rust-lang:master Jun 12, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants