Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Apple visionOS support #503

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

QuentinPerez
Copy link

Motivation

Add the support of Apple VisionOS 121419

Solution

Add target_os = "visionos"

@Thomasdezeeuw
Copy link
Collaborator

Can you add the target to the CI and local dev?

  • target: ["aarch64-apple-ios", "aarch64-linux-android", "x86_64-apple-darwin", "x86_64-unknown-fuchsia", "x86_64-pc-windows-msvc", "x86_64-pc-solaris", "x86_64-unknown-freebsd", "x86_64-unknown-illumos", "x86_64-unknown-linux-gnu", "x86_64-unknown-linux-musl", "x86_64-unknown-netbsd", "x86_64-unknown-redox", "armv7-linux-androideabi", "i686-linux-android"]
  • TARGETS ?= "aarch64-apple-ios" "aarch64-linux-android" "x86_64-apple-darwin" "x86_64-unknown-fuchsia" "x86_64-pc-windows-msvc" "x86_64-pc-solaris" "x86_64-unknown-freebsd" "x86_64-unknown-illumos" "x86_64-unknown-linux-gnu" "x86_64-unknown-linux-musl" "x86_64-unknown-netbsd" "x86_64-unknown-redox" "armv7-linux-androideabi" "i686-linux-android"

@QuentinPerez
Copy link
Author

@Thomasdezeeuw do you mind if I use target_env = "apple" ? Instead of changing this every time Apple releases a new device

@Thomasdezeeuw
Copy link
Collaborator

@Thomasdezeeuw do you mind if I use target_env = "apple" ? Instead of changing this every time Apple releases a new device

I think that is deprecated. Or was that target_family?

@Thomasdezeeuw
Copy link
Collaborator

@Thomasdezeeuw do you mind if I use target_env = "apple" ? Instead of changing this every time Apple releases a new device

I think that is deprecated. Or was that target_family?

target_vendor is being deprecated: rust-lang/rust#100343. For now let's stick with explicit OS, I don't really want to deal with all the target stuff a the moment, at least we know that this works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants