Add support for sendmmsg/recvmmsg #494
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FreeBSD use a `size_t` for the `len` argument, while other UNIX-likes use an `unigned int`.
From a quick glance, Windows does not have the equivalent syscall in the WinSock API.
Tuetuopay
force-pushed
the
mmsg
branch
2 times, most recently
from
cd55c15
to
f6cfed8
Compare
This one is great. The whole unix world uses an int for the flags, and documents it as such. But musl uses an unsigned int there [1], while still documenting a signed int. This API is cursed. [1]: https://git.musl-libc.org/cgit/musl/tree/include/sys/socket.h?id=39838619bb8b65a8897abcfda8c17ad6de0115d8#n70
For some braindead reason, old versions of android on 32 bit defined socklen_t to be an int, instead of the unsigned int it was everywhere else.
Sadly yes, but this is not possible because |
| target_vendor = "apple" | ||
| )) | ||
| ))] | ||
| pub struct MmsgHdr<'addr, 'bufs, 'control> { |
There was a problem hiding this comment.
What about matching mmsghdr here? For example
pub struct MmsgHdr<'addr, 'bufs, 'control> {
msg: MsgHdr,
len: libc::c_uint,
}This way the caller can decide if they want to use a Vec, a slice an array or something else.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to add support for the
sendmmsg/recvmmsgsyscalls.The API exposed here is a bit simplified, where the "user friendly" functions don't expose the scatter/gather stuff (the
_vectoredvariants found forrecvmsg/sendmsg). This was not exposed to not blow up the API surface, while keeping the functionality usingMmsgHdr(Mut)for advanced usages.Thanks!