Socket option for IP_MULTICAST_ALL & IPV6_MULTICAST_ALL for linux #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thomasdezeeuw
approved these changes
Dec 18, 2023
|
Thanks @mzachar |
|
Shit, actually this is missing a test. @mzachar can you add something like the following: https://github.com/rust-lang/socket2/blob/master/tests/socket.rs#L1322? |
|
Certainly! Is it ok If I push new commit here? |
I think you'll need to open a new pr. |
mzachar
added a commit
to mzachar/socket2
that referenced
this pull request
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added socket options for IP_MULTICAST_ALL & IPV6_MULTICAST_ALL which can be used to filter multicast packets received on the socket only from the groups that have been explicitly joined.
Useful when used in combination with SO_REUSEPORT