Add v4 and v6 versions of bind_device_by_index. #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pinkisemils
force-pushed
the
add-ipv6-bind-by-index
branch
from
5d3296b
to
975f678
Compare
pinkisemils
force-pushed
the
add-ipv6-bind-by-index
branch
from
975f678
to
f45c480
Compare
koalamay
approved these changes
May 11, 2023
pinkisemils
force-pushed
the
add-ipv6-bind-by-index
branch
from
f45c480
to
dc576c8
Compare
Thomasdezeeuw
approved these changes
May 23, 2023
|
@pinkisemils if you apply my suggested changes it should fix the CI. |
pinkisemils
force-pushed
the
add-ipv6-bind-by-index
branch
2 times, most recently
from
4d1e699
to
5262f5f
Compare
src/sys/unix.rs
Outdated
| @@ -1833,6 +1833,33 @@ impl crate::Socket { | |||
| .map(|_| ()) | |||
| } | |||
|
|
|||
| /// This method is deprecated, use [`Socket2::bind_device_by_index_v4`]. | |||
There was a problem hiding this comment.
Suggested change
| /// This method is deprecated, use [`Socket2::bind_device_by_index_v4`]. | |
| /// This method is deprecated, use [`Socket::bind_device_by_index_v4`]. | |
| /// | |
| /// [`Socket::bind_device_by_index_v4`]: crate::Socket::bind_device_by_index_v4 |
src/sys/unix.rs
Outdated
| let index = | ||
| unsafe { getsockopt::<libc::c_uint>(self.as_raw(), IPPROTO_IP, libc::IP_BOUND_IF)? }; | ||
| Ok(NonZeroU32::new(index)) | ||
| } | ||
|
|
||
| /// This method is deprecated, use [`Socket::device_index_v4`]. |
There was a problem hiding this comment.
Suggested change
| /// This method is deprecated, use [`Socket::device_index_v4`]. | |
| /// This method is deprecated, use [`Socket::device_index_v4`]. | |
| /// | |
| /// [`Socket::device_index_v4`]: crate::Socket::device_index_v4 |
pinkisemils
force-pushed
the
add-ipv6-bind-by-index
branch
from
5262f5f
to
28d6de7
Compare
|
Thanks for sticking with this @pinkisemils, sorry it took a little while. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added IPvX versioned functions for
bind_device_by_indexand deprecated the original, as discussed in #413.I've added a change log entry (and thus tentatively declaring a new verison), but I'm unsure if that's the correct thing to do here.