Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update fuchsia target triple to fix CI failure #423

Merged
merged 1 commit into from
Apr 3, 2023
Merged

Update fuchsia target triple to fix CI failure #423

merged 1 commit into from
Apr 3, 2023

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented Apr 1, 2023

https://github.com/rust-lang/socket2/actions/runs/4582046779/jobs/8091994019

error: component 'rust-std' for target 'x86_64-fuchsia' is unavailable for download for channel 'stable'

This is due to the following change in Rust 1.68:

https://github.com/rust-lang/rust/blob/master/RELEASES.md#version-1680-2023-03-09

Add vendor to Fuchsia's target triple

@mokeyish mokeyish mentioned this pull request Apr 1, 2023
Closed
chansuke
chansuke approved these changes Apr 2, 2023
View reviewed changes
Copy link
Collaborator

@chansuke chansuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for me, thank you.

@Thomasdezeeuw Thomasdezeeuw merged commit b39fdc6 into rust-lang:master Apr 3, 2023
31 checks passed
@Thomasdezeeuw
Copy link
Collaborator

Thanks @taiki-e

@taiki-e taiki-e deleted the fuchsia branch April 3, 2023 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chansuke chansuke chansuke approved these changes

@Thomasdezeeuw Thomasdezeeuw Thomasdezeeuw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@taiki-e @Thomasdezeeuw @chansuke