Add multicast SSM join and leave for IPv4 (IGMP) #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the review. Also yes, there is an IPv6 equivalent (MLD) but the sockops isn't as supported on many platforms. E.g., MCAST_JOIN_SOURCE_GROUP is the generic sockop that could be used for both IPv4 and IPv6 but it isn't working on MacOS. I will probably check out on what platforms they do work and then add them to libc. |
Thomasdezeeuw
approved these changes
Apr 19, 2022
|
Thanks @MaxF12
If you could add that in a follow up pr that would be great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds join_ssm_v4 and leave_ssm_v4 to allow sockets to include source when joining a multicast group. ASM multicast has been deprecated for inter domain use by the IETF, so SSM is an important functionality to have.
Also see this topic on Rust internals.