Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to bind socket to FIB on a FreeBSD #271
Add support to bind socket to FIB on a FreeBSD #271
Changes from all commits
20cfe8b
8e1f5f6
5cdc33a
98767a5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to https://www.freebsd.org/cgi/man.cgi?query=setfib&sektion=2
fib
should be au16
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
setfib - it's another syscall, that set FIB for current process, so all sockets will have specified fib by default.
setsockopt set fib only for exact socket.
In freebsd sources SO_SETFIB using with int.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, but it's the same option right? That system call just does it process wide.
But in C 80% of the input is an
int
, which b.t.w only has to be 16 bits. However we should try to provide a type that matches the expected input better. For example you're already using an unsigned integer, not a signed one.P.S. please don't resolve conversations that aren't resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've check with the FreeBSD discord and they recommend
u32
as well so going with that.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we will take a look on freebsd sources:
user side
https://github.com/freebsd/freebsd-src/blob/main/sbin/route/route.c
it uses exactly int
at kernel side (https://github.com/freebsd/freebsd-src/blob/main/sys/sys/socketvar.h) field so_fibnum also has type int.
FreeBSD has only up to 16 FIBs and FIB should not be negative. So I think it for possible future extensions.