Add test for cli ui #3205
Merged
Add test for cli ui #3205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hi-rustin
force-pushed
the
rustin-patch-cli-ui
branch
from
8bf8c7f
to
57826e0
Compare
Merged
hi-rustin
force-pushed
the
rustin-patch-cli-ui
branch
2 times, most recently
from
5686001
to
8014377
Compare
rbtcollins
reviewed
Feb 11, 2023
rbtcollins
reviewed
Feb 11, 2023
rbtcollins
reviewed
Feb 11, 2023
| rustup-init[EXE] [FLAGS] [OPTIONS] | ||
|
|
||
| FLAGS: | ||
| -v, --verbose Enable verbose output |
There was a problem hiding this comment.
I'm not sure if this will be stable as clap evolves - we may want to do things like
--verbose[...] Enable verbose output : but we can do that if we need to, not right now ;)
There was a problem hiding this comment.
Yes. we can update it if we need to.
Thanks for your review! 💚 💙 💜 💛 ❤️
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
hi-rustin
force-pushed
the
rustin-patch-cli-ui
branch
from
8014377
to
0facdf6
Compare
rbtcollins
reviewed
Feb 11, 2023
| let rustup = trycmd::cargo::cargo_bin("rustup"); | ||
| t.register_bin("rustup-init", &rustup_init); | ||
| // Copy rustup-init to rustup so that the tests can run it. | ||
| fs::copy(&rustup_init, &rustup).unwrap(); |
There was a problem hiding this comment.
You could also export RUSTUP_FORCE_ARG0='rust', but the copy is fine.
rbtcollins
approved these changes
Feb 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #3064 (comment)
Add ui tests for cli. Then we can try to bump clap's version.
Some notes:
...to ignore the first line of the subcommand bin name.mancommand on windows, we need to skip the man's test on windows.