Let Clap wrap help texts automatically #3070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the `rustup help show` and other help texts much more readable on my terminal.
hi-rustin
approved these changes
Sep 14, 2022
|
I have a question: does this help for #2920? Because I found it still broken the line. |
|
Hi @hi-rustin, thanks for testing it! I'm afraid the fix for wrapping URLs was only released in Clap 3.1.16, and Rustup is still using Clap 2. So perhaps I could work on updating to the new Clap version first? |
|
Hah, it turns out that @zohnannor has prepared the Clap update already in #3064. |
Got it. Thanks! |
|
r? @kinnison Could you please take a look? It looks good to me. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the
rustup help showand other help texts much more readable on my terminal.This enables the optional
wrap_helpfeature in Clap. For me,rustup help showlooks like this without the feature:With
wrap_help, I seeI find the second much nicer to read. (I'm a fan of wrapping lines, I maintain the underlying Textwrap library used by Clap 馃槃)