Slabs #2756
Merged
Slabs #2756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbtcollins
force-pushed
the
slabs
branch
4 times, most recently
from
33a7d08
to
5c164c0
Compare
|
Hiding the 'using 500.0MiB' message has broken a number of the 'exact' tests I think. |
We think we have memory fragmentation causing failed extraction in Windows containers and smaller Unix devices. Writes of both full objects and streamed objects now re-use the Vec via a sharded-slab implementation. To facilitate the more complicated memory logic, buffer limit management is now integrated into the IO Executor: the immediate executor doesn't limit at all as no outstanding buffers occur, and the threaded executor tracks both the total allocated buffers as well as whether a reusable buffer is available.
|
I think this is looking good. I'd just like to know what the memory consumption difference is between 1.24.1 and this for Windows runs, because my gut feeling is that it's using more RAM under Linux, though that may simply be that it's being more efficient with the RAM I have. |
|
I have asked someone on #2759 to try an artifact from this PR. |
|
I have a number of non-rustup things to do: it will be a week or so before I can sit down and dig up a massif or similar for windows. |
|
Based on the experience in #2759 I'm going to merge this so we can push out a 1.24.2 for beta again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
be smarter about memory management to reduce hypothetical memory fragmentation