Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove deprecated dependency assert_cli #3249

Merged
merged 2 commits into from
Dec 17, 2018
Merged

remove deprecated dependency assert_cli #3249

merged 2 commits into from
Dec 17, 2018

Conversation

andjo403
Copy link
Contributor

No description provided.

scampi
scampi approved these changes Dec 14, 2018
View reviewed changes
Copy link
Contributor

@scampi scampi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, given assert_cli was used in only one place, then it seems fine to not depend on it.

src/test/mod.rs Outdated Show resolved Hide resolved
@andjo403
Copy link
Contributor Author

thanks for the fast feedback

@andjo403
Copy link
Contributor Author

the faults in ci is:
limited_independence_of_irrelevant_alternatives runs for a long time in cargo integration see rust-lang/cargo#6258 for tracing of this fault

and futures-test-preview do not compile

nrc
nrc approved these changes Dec 17, 2018
View reviewed changes
Copy link
Member

@nrc nrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nrc nrc merged commit 16c292d into rust-lang:master Dec 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nrc nrc nrc approved these changes

@scampi scampi scampi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andjo403 @nrc @scampi