Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional methods to the Demand type #99583

Merged
merged 2 commits into from Sep 2, 2022
Merged

Add additional methods to the Demand type #99583

merged 2 commits into from Sep 2, 2022

Conversation

shepmaster
Copy link
Member

@shepmaster shepmaster commented Jul 22, 2022 •
edited

This adds on to the original tracking issue #96024

r? @yaahc

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Jul 22, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 22, 2022
yaahc
yaahc requested changes Aug 2, 2022
View reviewed changes
library/core/src/any.rs Outdated Show resolved Hide resolved
library/core/src/any.rs Show resolved Hide resolved
library/core/src/any.rs Outdated Show resolved Hide resolved
library/core/src/any.rs Outdated Show resolved Hide resolved
library/core/src/any.rs Outdated Show resolved Hide resolved
library/core/src/any.rs Outdated Show resolved Hide resolved
@shepmaster shepmaster marked this pull request as ready for review August 3, 2022 01:38
@rustbot
Copy link
Collaborator

rustbot commented Aug 3, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@shepmaster shepmaster added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 3, 2022
yaahc
yaahc reviewed Aug 3, 2022
View reviewed changes
library/core/src/any.rs Outdated Show resolved Hide resolved
library/core/src/any.rs Outdated Show resolved Hide resolved
@shepmaster
Support eager and lazy methods for providing references and values
38de102 
There are times where computing a value may be cheap, or where
computing a reference may be expensive, so this fills out the
possibilities.
@shepmaster
Add `Provider::{would_be_satisfied_by_value_of,would_be_satisfied_by_…
260ec93 
…ref_of}`

While the `provide_*` methods already short-circuit when a value has
been provided, there are times where an expensive computation is
needed to determine if the `provide_*` method can even be called.
@yaahc
Copy link
Member

yaahc commented Aug 31, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Aug 31, 2022

📌 Commit 260ec93 has been approved by yaahc

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 31, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Sep 1, 2022
@matthiaskrgr
Rollup merge of rust-lang#99583 - shepmaster:provider-plus-plus, r=yaahc
4648fed 
Add additional methods to the Demand type

This adds on to the original tracking issue rust-lang#96024

r? `@yaahc`
@matthiaskrgr matthiaskrgr mentioned this pull request Sep 1, 2022
Closed
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Sep 1, 2022
@Dylan-DPC
Rollup merge of rust-lang#99583 - shepmaster:provider-plus-plus, r=yaahc
0453081 
Add additional methods to the Demand type

This adds on to the original tracking issue rust-lang#96024

r? ``@yaahc``
@Dylan-DPC Dylan-DPC mentioned this pull request Sep 1, 2022
Closed
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Sep 1, 2022
@Dylan-DPC
Rollup merge of rust-lang#99583 - shepmaster:provider-plus-plus, r=yaahc
af0d634 
Add additional methods to the Demand type

This adds on to the original tracking issue rust-lang#96024

r? ```@yaahc```
@Dylan-DPC Dylan-DPC mentioned this pull request Sep 1, 2022
Closed
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Sep 1, 2022
@Dylan-DPC
Rollup merge of rust-lang#99583 - shepmaster:provider-plus-plus, r=yaahc
a230b73 
Add additional methods to the Demand type

This adds on to the original tracking issue rust-lang#96024

r? ````@yaahc````
@Dylan-DPC Dylan-DPC mentioned this pull request Sep 1, 2022
Closed
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Sep 1, 2022
@Dylan-DPC
Rollup merge of rust-lang#99583 - shepmaster:provider-plus-plus, r=yaahc
a05d856 
Add additional methods to the Demand type

This adds on to the original tracking issue rust-lang#96024

r? `````@yaahc`````
@Dylan-DPC Dylan-DPC mentioned this pull request Sep 1, 2022
Closed
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Sep 1, 2022
@Dylan-DPC
Rollup merge of rust-lang#99583 - shepmaster:provider-plus-plus, r=yaahc
fbe63c2 
Add additional methods to the Demand type

This adds on to the original tracking issue rust-lang#96024

r? ``````@yaahc``````
@Dylan-DPC Dylan-DPC mentioned this pull request Sep 1, 2022
Closed
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Sep 2, 2022
@Dylan-DPC
Rollup merge of rust-lang#99583 - shepmaster:provider-plus-plus, r=yaahc
c20fe7c 
Add additional methods to the Demand type

This adds on to the original tracking issue rust-lang#96024

r? `@yaahc`
@Dylan-DPC Dylan-DPC mentioned this pull request Sep 2, 2022
Closed
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Sep 2, 2022
@Dylan-DPC
Rollup merge of rust-lang#99583 - shepmaster:provider-plus-plus, r=yaahc
2d677c8 
Add additional methods to the Demand type

This adds on to the original tracking issue rust-lang#96024

r? ``@yaahc``
@Dylan-DPC Dylan-DPC mentioned this pull request Sep 2, 2022
Closed
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Sep 2, 2022
@Dylan-DPC
Rollup merge of rust-lang#99583 - shepmaster:provider-plus-plus, r=yaahc
a53e417 
Add additional methods to the Demand type

This adds on to the original tracking issue rust-lang#96024

r? ```@yaahc```
@Dylan-DPC Dylan-DPC mentioned this pull request Sep 2, 2022
Closed
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Sep 2, 2022
@Dylan-DPC
Rollup merge of rust-lang#99583 - shepmaster:provider-plus-plus, r=yaahc
4038521 
Add additional methods to the Demand type

This adds on to the original tracking issue rust-lang#96024

r? ````@yaahc````
@Dylan-DPC Dylan-DPC mentioned this pull request Sep 2, 2022
Closed
@GuillaumeGomez GuillaumeGomez mentioned this pull request Sep 2, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 2, 2022
@bors
Auto merge of rust-lang#101318 - GuillaumeGomez:rollup-qsr51z4, r=Gui…
9353538 
…llaumeGomez

Rollup of 9 pull requests

Successful merges:

 - rust-lang#97739 (Uplift the `let_underscore` lints from clippy into rustc.)
 - rust-lang#99583 (Add additional methods to the Demand type)
 - rust-lang#100147 (optimization of access level table construction)
 - rust-lang#100552 (rustc_target: Add a compatibility layer to separate internal and user-facing linker flavors)
 - rust-lang#100827 (Simplify MIR opt tests)
 - rust-lang#101166 (Generate error index with mdbook instead of raw HTML pages)
 - rust-lang#101294 (Fix rust-lang#100844 rebase accident)
 - rust-lang#101298 (rustdoc: remove unused CSS `#main-content > .since`)
 - rust-lang#101304 (Add autolabels for `A-query-system`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 0e82dc9 into rust-lang:master Sep 2, 2022
@rustbot rustbot added this to the 1.65.0 milestone Sep 2, 2022
@shepmaster shepmaster deleted the provider-plus-plus branch September 5, 2022 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaahc yaahc yaahc requested changes

Assignees

@yaahc yaahc

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.65.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@shepmaster @rustbot @yaahc @bors @rust-highfive