Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add crt-static for android #99421

Merged
merged 1 commit into from Aug 12, 2022
Merged

add crt-static for android #99421

merged 1 commit into from Aug 12, 2022

Conversation

Bryanskiy
Copy link
Contributor

No description provided.

@rustbot rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 18, 2022
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon.

Please see the contribution instructions for more information.

@rustbot
Copy link
Collaborator

rustbot commented Jul 18, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 18, 2022
@petrochenkov
Copy link
Contributor

r? @petrochenkov

@petrochenkov
Copy link
Contributor

CI says

    Updating crates.io index
error: failed to write /checkout/Cargo.lock
Caused by:
  failed to open: /checkout/Cargo.lock

Changes in Cargo.lock caused by libc override should also be committed/pushed.

petrochenkov
petrochenkov reviewed Jul 18, 2022
View reviewed changes
library/std/src/lib.rs Outdated Show resolved Hide resolved
library/unwind/Cargo.toml Outdated Show resolved Hide resolved
library/unwind/build.rs Show resolved Hide resolved
@petrochenkov
Copy link
Contributor

Blocked on rust-lang/libc#2848.

@petrochenkov petrochenkov added S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 18, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Bryanskiy Bryanskiy force-pushed the android-crt-static branch 2 times, most recently from 4803583 to eeb69b0 Compare July 18, 2022 19:42
@petrochenkov petrochenkov mentioned this pull request Jul 30, 2022
Merged
@petrochenkov
Copy link
Contributor

rust-lang/libc#2848 has been merged and released, unblocking.
@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. labels Aug 9, 2022
petrochenkov
petrochenkov reviewed Aug 9, 2022
View reviewed changes
library/unwind/Cargo.toml Outdated Show resolved Hide resolved
library/unwind/src/lib.rs Show resolved Hide resolved
@Bryanskiy
Copy link
Contributor Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 10, 2022
petrochenkov
petrochenkov reviewed Aug 10, 2022
View reviewed changes
library/unwind/src/lib.rs Outdated Show resolved Hide resolved
library/unwind/src/lib.rs Outdated Show resolved Hide resolved
@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Aug 10, 2022

📌 Commit 874ee5b has been approved by petrochenkov

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 10, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Aug 11, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 11, 2022
@bors
Auto merge of rust-lang#100426 - matthiaskrgr:rollup-0ks4dou, r=matth…
2ed0f29 
…iaskrgr

Rollup of 13 pull requests

Successful merges:

 - rust-lang#93896 (rustdoc: make item-infos dimmer on dark theme)
 - rust-lang#99337 (rustdoc: simplify highlight.rs)
 - rust-lang#99421 (add crt-static for android)
 - rust-lang#99500 (Fix flags when using clang as linker for Fuchsia)
 - rust-lang#99511 (make raw_eq precondition more restrictive)
 - rust-lang#99992 (Add `x.sh` and `x.ps1` shell scripts)
 - rust-lang#100112 (Fix test: chunks_mut_are_send_and_sync)
 - rust-lang#100203 (provide correct size hint for unsupported platform `CommandArgs`)
 - rust-lang#100307 (Fix rust-lang#96847)
 - rust-lang#100350 (Stringify non-shorthand visibility correctly)
 - rust-lang#100374 (Improve crate selection on rustdoc search results page)
 - rust-lang#100392 (Simplify visitors)
 - rust-lang#100418 (Add stability attributes to BacktraceStatus variants)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 6737549 into rust-lang:master Aug 12, 2022
@rustbot rustbot added this to the 1.65.0 milestone Aug 12, 2022
@Bryanskiy Bryanskiy deleted the android-crt-static branch May 18, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrochenkov petrochenkov petrochenkov left review comments

Assignees

@petrochenkov petrochenkov

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.65.0
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@Bryanskiy @rust-highfive @rustbot @petrochenkov @rust-log-analyzer @bors @Mark-Simulacrum