Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[beta] Beta backports #97631

Merged
merged 4 commits into from
Jun 2, 2022
Merged

[beta] Beta backports #97631

merged 4 commits into from
Jun 2, 2022

Commits on Jun 1, 2022

  1. [beta] Update cargo

    @ehuss
    ehuss committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    04e8835 View commit details
    Browse the repository at this point in the history

  2. Rollup merge of rust-lang#97032 - est31:unused_macro_rules, r=petroch… 

    …enkov

Allow the unused_macro_rules lint for now

It was newly added by rust-lang#96150 with warn by default, which is great as it gave exposure to the community, and their feedback gave me ideas for improvements.

Allowing the lint is good for two reasons:

* It makes the transition easier as e.g. allow directives won't fire the unknown lint warning once it is turned to warn by default in the future. The [commit that allowed the lint in fuchsia](https://fuchsia.googlesource.com/fuchsia/+/9d8f96517c3963de2f0e25598fd36061914524cd%5E%21/) had to allow unknown lints for example.
This is especially important compared to other lints in the unused group,
because the _ prefix trick doesn't exist for macro rules, allowing is the
only option (either of unused_macro_rules, or of the entire unused group,
but that is not as informative to readers). Allowing the lint also makes it
possible to work on possible heuristics for disabling the macro in specific
cases.
* It gives time for implementing heuristics for when to suppress the lint, e.g.
when `compile_error!` is invoked by that arm (so it's only there to yield an error).

See: rust-lang#96150 (comment)

I would also like this to be backported to the 1.62 beta branch (cc rust-lang#97016).
    @matthiaskrgr @ehuss
    matthiaskrgr authored and ehuss committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    0723488 View commit details
    Browse the repository at this point in the history

  3. Rollup merge of rust-lang#97303 - compiler-errors:arg-typos, r=jackh726 

    Fix some typos in arg checking algorithm

Fixes rust-lang#97197

Also fixes a typo where if we're missing args A, B, C, we actually say A, B, B
    @Dylan-DPC @ehuss
    Dylan-DPC authored and ehuss committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    0a2d181 View commit details
    Browse the repository at this point in the history

  4. Rollup merge of rust-lang#97328 - petrochenkov:nativice, r=michaelwoe… 

    …rister

rustc: Fix ICE in native library error reporting

Fixes rust-lang#97299
    @Dylan-DPC @ehuss
    Dylan-DPC authored and ehuss committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    054a2bd View commit details
    Browse the repository at this point in the history