Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop keeping metadata in memory before writing it to disk #96544

Merged
merged 32 commits into from
Jul 15, 2022
Merged

Stop keeping metadata in memory before writing it to disk #96544

merged 32 commits into from
Jul 15, 2022

Commits on Jul 2, 2022

  1. move emit_metadata to rustc_metadata::fs

    @m-ysk
    m-ysk committed Jul 2, 2022
    Configuration menu
    Copy the full SHA
    709a782 View commit details
    Browse the repository at this point in the history

  2. move encode_and_write_metadata to rustc_metadata::fs

    @m-ysk
    m-ysk committed Jul 2, 2022
    Configuration menu
    Copy the full SHA
    5d9ba49 View commit details
    Browse the repository at this point in the history

  3. use rustc_serialize::opaque::FileEncoder

    @m-ysk
    m-ysk committed Jul 2, 2022
    Configuration menu
    Copy the full SHA
    e7f95ac View commit details
    Browse the repository at this point in the history

  4. call emit_metadata only when metadata_kind is None

    @m-ysk
    m-ysk committed Jul 2, 2022
    Configuration menu
    Copy the full SHA
    bb75c4b View commit details
    Browse the repository at this point in the history

  5. construct EncodedMetadata in encode_and_write_metadata

    @m-ysk
    m-ysk committed Jul 2, 2022
    Configuration menu
    Copy the full SHA
    c26c461 View commit details
    Browse the repository at this point in the history

  6. hold Mmap in EncodedMetadata

    @m-ysk
    m-ysk committed Jul 2, 2022
    Configuration menu
    Copy the full SHA
    8cfa7ca View commit details
    Browse the repository at this point in the history

  7. write to a temporary file in Decodable for EncodedMetadata

    @m-ysk
    m-ysk committed Jul 2, 2022
    Configuration menu
    Copy the full SHA
    336af60 View commit details
    Browse the repository at this point in the history

  8. seek and write the root position to the metadata file

    @m-ysk
    m-ysk committed Jul 2, 2022
    Configuration menu
    Copy the full SHA
    34f8889 View commit details
    Browse the repository at this point in the history

  9. use BufReader for counting zero bytes

    @m-ysk
    m-ysk committed Jul 2, 2022
    Configuration menu
    Copy the full SHA
    1be5805 View commit details
    Browse the repository at this point in the history

  10. add Send to the argument type of encode_metadata

    @m-ysk
    m-ysk committed Jul 2, 2022
    Configuration menu
    Copy the full SHA
    aa8e064 View commit details
    Browse the repository at this point in the history

  11. fix a typo

    @m-ysk
    m-ysk committed Jul 2, 2022
    Configuration menu
    Copy the full SHA
    1c2cc68 View commit details
    Browse the repository at this point in the history

  12. import all necessary parts of rustc_metadata::fs

    @m-ysk
    m-ysk committed Jul 2, 2022
    Configuration menu
    Copy the full SHA
    5aac75a View commit details
    Browse the repository at this point in the history

  13. remove non_durable_rename in rustc_interface::util

    @m-ysk
    m-ysk committed Jul 2, 2022
    Configuration menu
    Copy the full SHA
    b28b7c9 View commit details
    Browse the repository at this point in the history

  14. write the root position at the end

    @m-ysk
    m-ysk committed Jul 2, 2022
    Configuration menu
    Copy the full SHA
    c8e49e4 View commit details
    Browse the repository at this point in the history

  15. call EncodedMetadata::empty in case of MetadataKind::None

    @m-ysk
    m-ysk committed Jul 2, 2022
    Configuration menu
    Copy the full SHA
    1ead92d View commit details
    Browse the repository at this point in the history

  16. seek before counting zero bytes

    @m-ysk
    m-ysk committed Jul 2, 2022
    Configuration menu
    Copy the full SHA
    e11dd80 View commit details
    Browse the repository at this point in the history

  17. insert dummy 4 bytes to avoid the breaking change

    @m-ysk
    m-ysk committed Jul 2, 2022
    Configuration menu
    Copy the full SHA
    8d35ff1 View commit details
    Browse the repository at this point in the history

  18. create tmp directory if there is no parent directory

    @m-ysk
    m-ysk committed Jul 2, 2022
    Configuration menu
    Copy the full SHA
    dcb599f View commit details
    Browse the repository at this point in the history

  19. use &Path instead of AsRef<Path>

    @m-ysk
    m-ysk committed Jul 2, 2022
    Configuration menu
    Copy the full SHA
    47c3689 View commit details
    Browse the repository at this point in the history

  20. define MmapMut and use it in Decodable impl

    @m-ysk
    m-ysk committed Jul 2, 2022
    Configuration menu
    Copy the full SHA
    c57d778 View commit details
    Browse the repository at this point in the history

  21. flush and assert when counting zero bytes

    @m-ysk
    m-ysk committed Jul 2, 2022
    Configuration menu
    Copy the full SHA
    7eb64b4 View commit details
    Browse the repository at this point in the history

  22. create an empty file even in case of MetadataKind::None

    @m-ysk
    m-ysk committed Jul 2, 2022
    Configuration menu
    Copy the full SHA
    03de5c4 View commit details
    Browse the repository at this point in the history

  23. add a comment about the drop order for EncodedMetadata

    @m-ysk
    m-ysk committed Jul 2, 2022
    Configuration menu
    Copy the full SHA
    ec64b4c View commit details
    Browse the repository at this point in the history

  24. Revert "write the root position at the end" 

    This reverts commit 44f66429e1fdba2cd167b4033f04f462a368b717.
    @m-ysk
    m-ysk committed Jul 2, 2022
    Configuration menu
    Copy the full SHA
    34e44e5 View commit details
    Browse the repository at this point in the history

  25. refactor encode_and_write_metadata

    @m-ysk
    m-ysk committed Jul 2, 2022
    Configuration menu
    Copy the full SHA
    0928061 View commit details
    Browse the repository at this point in the history

  26. fix an incorrect filename for an error message

    @m-ysk
    m-ysk committed Jul 2, 2022
    Configuration menu
    Copy the full SHA
    63dec94 View commit details
    Browse the repository at this point in the history

  27. add some comments for encode_and_write_metadata

    @m-ysk
    m-ysk committed Jul 2, 2022
    Configuration menu
    Copy the full SHA
    ad55481 View commit details
    Browse the repository at this point in the history

  28. add a comment about counting zero bytes

    @m-ysk
    m-ysk committed Jul 2, 2022
    Configuration menu
    Copy the full SHA
    3e30935 View commit details
    Browse the repository at this point in the history

  29. avoid holding the temp_dir for empty metadata file

    @m-ysk
    m-ysk committed Jul 2, 2022
    Configuration menu
    Copy the full SHA
    ea0e0f4 View commit details
    Browse the repository at this point in the history

  30. seek instead of opening a new file handle

    @m-ysk
    m-ysk committed Jul 2, 2022
    Configuration menu
    Copy the full SHA
    a206121 View commit details
    Browse the repository at this point in the history

  31. fall back on the blank path if out_filename is blank

    @m-ysk
    m-ysk committed Jul 2, 2022
    Configuration menu
    Copy the full SHA
    7a5e773 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2022

  1. ensure rustc does not panic by the test for issue-26092

    @m-ysk
    m-ysk committed Jul 3, 2022
    Configuration menu
    Copy the full SHA
    1147d50 View commit details
    Browse the repository at this point in the history