Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hacks in make_token_stream. #96543

Merged
merged 2 commits into from
May 11, 2022

Commits on Apr 29, 2022

  1. Remove hacks in make_token_stream.

    `make_tokenstream` has three commented hacks, and a comment at the top
    referring to rust-lang#67062. These hacks have no observable effect, at least as judged
    by running the test suite. The hacks were added in rust-lang#82608, with an explanation
    [here](rust-lang#82608 (comment)). It
    appears that one of the following is true: (a) they never did anything useful,
    (b) they do something useful but we have no test coverage for them, or (c)
    something has changed in the meantime that means they are no longer necessary.
    
    This commit removes the hacks and the comments, in the hope that (b) is not
    true.
    nnethercote committed Apr 29, 2022
    Configuration menu
    Copy the full SHA
    bb398ca View commit details
    Browse the repository at this point in the history

Commits on May 11, 2022

  1. Remove some unnecessary invisible delimiter checks.

    These seem to have no useful effect... they don't seem useful from a
    code inspection point of view, and they affect anything in the test
    suite.
    nnethercote committed May 11, 2022
    Configuration menu
    Copy the full SHA
    3cd8e98 View commit details
    Browse the repository at this point in the history