refactor write_output_file to merge two invocation paths into one. #93331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @oli-obk (rust-highfive has picked a reviewer for you, use r? to override) |
rustbot
added
the
T-compiler
rust-highfive
added
the
S-waiting-on-review
oli-obk
reviewed
Jan 26, 2022
| dwo_output_c.as_ptr(), | ||
| file_type, | ||
| ) | ||
| let dwo_output_c; |
There was a problem hiding this comment.
🤣 Wasn't there a twitter thread just yesterday about this pattern?
|
@bors r+ rollup |
|
📌 Commit 3d5c92096d817e13d6d7985b722e42c22714645d has been approved by |
bors
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
|
@bors r- rustfmt is unhappy. |
bors
added
S-waiting-on-author
|
r=me with rustfmt run |
Argh I cannot believe I messed that up. I thought I had my local builds set up to catch this... |
JohnCSimon
added
S-waiting-on-author
JohnCSimon
added
S-waiting-on-author
pnkfelix
force-pushed
the
refactor-write-output-file
branch
from
3d5c920
to
39f2529
Compare
This comment has been minimized.
This comment has been minimized.
pnkfelix
force-pushed
the
refactor-write-output-file
branch
from
39f2529
to
927de94
Compare
|
@bors r=oli-obk rollup |
|
📌 Commit 927de94 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 10, 2022
…askrgr Rollup of 6 pull requests Successful merges: - rust-lang#93331 (refactor write_output_file to merge two invocation paths into one.) - rust-lang#97928 (Removes debug settings from wasm32_unknown_emscripten default link args) - rust-lang#97940 (Use relative links instead of linking to doc.rust-lang.org when possible) - rust-lang#97941 (nit: Fixed several error_codes/Exxxx.md messages which used UpperCamelCase…) - rust-lang#97953 (Add regression test for rust-lang#54378) - rust-lang#97957 (Make `std::` prefix suggestion test `run-rustfix`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a trivial refactor I did while I was investigating issue #91671.