Avoid uneccessary clone of Annotatable

[eggyal]

Addresses FIXME comment created in #82608

r? @Aaron1011

[Aaron1011]

Very clever!

@bors try @rust-timer queue

[rust-timer]

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

[bors]

⌛ Trying commit d05e4d2 with merge 753a94276a9dacd5bd9033012456ea133392d9da...

[bors]

☀️ Try build successful - checks-actions
Build commit: 753a94276a9dacd5bd9033012456ea133392d9da (753a94276a9dacd5bd9033012456ea133392d9da)

[rust-timer]

Queued 753a94276a9dacd5bd9033012456ea133392d9da with parent db9d361, future comparison URL.

[rust-timer]

Finished benchmarking commit (753a94276a9dacd5bd9033012456ea133392d9da): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

[Aaron1011]

@bors r+

[bors]

📌 Commit d05e4d2 has been approved by Aaron1011

[bors]

⌛ Testing commit d05e4d2 with merge cd3e911336b2811285fa6f1c6808b9e533b3aada...

[rust-log-analyzer]

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

Processing message: Object({"id": Number(0), "jsonrpc": String("2.0"), "result": Object({"capabilities": Object({"codeActionProvider": Bool(true), "codeLensProvider": Object({"resolveProvider": Bool(false)}), "completionProvider": Object({"resolveProvider": Bool(true), "triggerCharacters": Array([String("."), String(":")])}), "definitionProvider": Bool(true), "documentFormattingProvider": Bool(true), "documentHighlightProvider": Bool(true), "documentRangeFormattingProvider": Bool(false), "documentSymbolProvider": Bool(true), "executeCommandProvider": Object({"commands": Array([String("rls.applySuggestion-5805"), String("rls.deglobImports-5805")])}), "hoverProvider": Bool(true), "implementationProvider": Bool(true), "referencesProvider": Bool(true), "renameProvider": Bool(true), "textDocumentSync": Number(2), "workspaceSymbolProvider": Bool(true)})})})
Processing message: Object({"jsonrpc": String("2.0"), "method": String("window/progress"), "params": Object({"done": Null, "id": String("progress_1"), "message": Null, "percentage": Null, "title": String("Building")})})
Processing message: Object({"jsonrpc": String("2.0"), "method": String("window/progress"), "params": Object({"done": Bool(true), "id": String("progress_1"), "message": Null, "percentage": Null, "title": String("Building")})})
Processing message: Object({"jsonrpc": String("2.0"), "method": String("window/progress"), "params": Object({"done": Null, "id": String("progress_0"), "message": Null, "percentage": Null, "title": String("Indexing")})})
Processing message: Object({"jsonrpc": String("2.0"), "method": String("textDocument/publishDiagnostics"), "params": Object({"diagnostics": Array([Object({"message": String("failed to load manifest for dependency `member_a`"), "range": Object({"end": Object({"character": Number(0), "line": Number(9999)}), "start": Object({"character": Number(0), "line": Number(0)})}), "severity": Number(1)})]), "uri": String("file:///checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/rlsit/t26/invalid_member_toml/member_a/dodgy_member/Cargo.toml")})})
error: test failed, to rerun pass '--test client'
thread 'client_invalid_member_toml_manifest' panicked at 'called `Result::unwrap()` on an `Err` value: Elapsed(())', src/tools/rls/tests/support/client/mod.rs:267:28
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Sending: Object({"id": Number(99999), "jsonrpc": String("2.0"), "method": String("shutdown"), "params": Null})
---
Verifying status of rls...
Verifying status of miri...
Verifying status of embedded-book...
Cloning into 'rust-toolstate'...
error: Tool `rls` has regressed from test-pass to test-fail during beta week.
{"cargo-miri":"test-fail","rls":"test-fail","book":"test-pass","embedded-book":"test-pass","nomicon":"test-pass","reference":"test-pass","rust-by-example":"test-pass","edition-guide":"test-pass","miri":"test-pass","rustbook":"test-fail"}Build completed unsuccessfully in 0:00:00

[bors]

💔 Test failed - checks-actions

[eggyal]

Well that's... interesting ?!

Spurious failure? Bug in MIRI? UB? Not sure what's going on here, but seems pretty unlikely for this PR to be at fault!

[Aaron1011]

@bors retry

[bors]

⌛ Testing commit d05e4d2 with merge 2a8a133a2ed4e53b278c343d15d35579efeac881...

[rust-log-analyzer]

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[bors]

💔 Test failed - checks-actions

[Aaron1011]

@bors try

[bors]

⌛ Trying commit d05e4d2 with merge 7b97bbc7df1cd184854ae0fc18f6a22f944800f6...

[bors]

☀️ Try build successful - checks-actions
Build commit: 7b97bbc7df1cd184854ae0fc18f6a22f944800f6 (7b97bbc7df1cd184854ae0fc18f6a22f944800f6)

[Aaron1011]

@bors retry

[bors]

⌛ Trying commit d05e4d2 with merge f049e60b9fedcaf4d463dd92f0ffe7eb9b62f029...

[bors]

☀️ Try build successful - checks-actions
Build commit: f049e60b9fedcaf4d463dd92f0ffe7eb9b62f029 (f049e60b9fedcaf4d463dd92f0ffe7eb9b62f029)

[Aaron1011]

@bors r+

[bors]

💡 This pull request was already approved, no need to approve it again.

• There's another pull request that is currently being tested, blocking this pull request: Deny warnings in rustdoc non-UI tests #91275

[bors]

📌 Commit d05e4d2 has been approved by Aaron1011

[bors]

⌛ Testing commit d05e4d2 with merge 2446a21...

[bors]

☀️ Test successful - checks-actions
Approved by: Aaron1011
Pushing 2446a21 to master...

[eggyal]

Hooray! But still... all rather suspicious. Is this a known issue?

[rust-timer]

Finished benchmarking commit (2446a21): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression