Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect gating of nonterminals in key-value attributes #85445

Closed
wants to merge 1 commit into from
Closed

Fix incorrect gating of nonterminals in key-value attributes #85445

wants to merge 1 commit into from

Commits on May 18, 2021

  1. Fix incorrect gating of nonterminals in key-value attributes 

    Fixes rust-lang#85432

When processing a `#[derive]` or `#[cfg_eval]` attribute, we need to
re-parse our attribute target, which requires flattenting all
`Nonterminals`. However, this caused us to incorrectly gate on a
(flattented) nonterminal in a key-value attribute, which is supposed to
be allowed.

Since we already perform this gating during the initial parse, we
suppress it in `capture_cfg` mode.
    @Aaron1011
    Aaron1011 committed May 18, 2021
    Configuration menu
    Copy the full SHA
    fd1e19e View commit details
    Browse the repository at this point in the history