Re-add support for parsing (and pretty-printing) inner-attributes in match body #85193
Conversation
…hin body of a `match`.
In other words, we can do `match EXPR { #![inner_attr] ARM_1 ARM_2 ... }` again.
I believe this unbreaks the only four crates that crater flagged as broken by PR 83312.
(I am putting this up so that the lang-team can check it out and decide whether
it changes their mind about what to do regarding PR 83312.)
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
pnkfelix
added
the
T-lang
pnkfelix
changed the title
|
nominating for T-lang meeting. If we're moving on this, I want it to happen on the 1.54 release (i.e. when PR #83312 landed). It would be nice to do it without having to beta-backport anything. |
pnkfelix
changed the title
|
This seems reasonable, and should address the concerns in flight about having removed inner attributes previously. Let's see if we have lang-team consensus on this. Note that this doesn't mean "we want to support attrs here", this is more "we acknowledge that there was breakage here and this fixes that breakage". @rfcbot merge |
|
Team member @joshtriplett has proposed to merge this. The next step is review by the rest of the tagged team members: No concerns currently listed. Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for info about what commands tagged team members can give me. |
rfcbot
added
proposed-final-comment-period
|
@rfcbot reviewed I'm not actually fond of inner attributes here, but re-enabling this to fix actual breakage sounds reasonable. |
rfcbot
added
final-comment-period
|
🔔 This is now entering its final comment period, as per the review above. 🔔 |
|
If this is going to get into the 1.54 release without a beta-backport, it need to land before Friday 10 June. it was assigning for review by @matthewjasper but I'm not actually sure that auto-assignment made perfect sense. Nominating for (hopefully quick) discussion at today's compiler team meeting, to mainly see if I can pull in someone to do a review with quick turnaround. |
pnkfelix
added
I-nominated
T-compiler
rfcbot
added
finished-final-comment-period
|
The final comment period, with a disposition to merge, as per the review above, is now complete. As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed. The RFC will be merged soon. |
ehuss
added
the
beta-nominated
|
Nominating for beta since this didn't merge in time. |
rustbot
added
the
beta-accepted
|
We should get this reviewed and merged. Perhaps @petrochenkov or @Aaron1011 could take a look? I'm not sure who is familiar with this area... |
|
@bors r+ This looks pretty straightforward. |
|
📌 Commit 8ce761d has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
cuviper
removed
the
beta-nominated
[beta] backports - rustfmt: load nested out-of-line mods correctly rust-lang#86424 - Re-add support for parsing (and pretty-printing) inner-attributes in match body rust-lang#85193 - Revert "List trait impls before methods from deref in the sidebar ..." rust-lang#86564 - Revert "Don't load all extern crates unconditionally" rust-lang#85749 r? `@Mark-Simulacrum`
Re-add support for parsing (and pretty-printing) inner-attributes within body of a
match.In other words, we can do
match EXPR { #![inner_attr] ARM_1 ARM_2 ... }again.I believe this unbreaks the only four crates that crater flagged as broken by PR #83312.
(I am putting this up so that the lang-team can check it out and decide whether it changes their mind about what to do regarding PR #83312.)