Give a better error when --theme is not a CSS file #83705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyn514
added
T-rustdoc
rust-highfive
added
the
S-waiting-on-review
|
Please add a |
jyn514
force-pushed
the
theme-error
branch
2 times, most recently
from
1ef3609
to
1f11663
Compare
This comment has been minimized.
This comment has been minimized.
Before: ``` error: invalid argument: "bacon.toml" ``` After: ``` error: invalid argument: "bacon.toml" | = help: arguments to --theme must be CSS files ```
camelid
reviewed
Apr 3, 2021
| // FIXME Why is -L here? | ||
| rustc.arg(input_file); //.arg("-L").arg(&self.config.build_base); | ||
| rustc.arg(input_file); |
There was a problem hiding this comment.
Why is this change part of this PR?
There was a problem hiding this comment.
Oh, I noticed it while looking for {{src-base}} and it looked super outdated. It's working fine without -L so I don't think the comment is necessary.
GuillaumeGomez
approved these changes
Apr 5, 2021
|
Thanks! @bors: r+ rollup |
|
📌 Commit 29eb686 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 5, 2021
Rollup of 5 pull requests Successful merges: - rust-lang#83368 (Add `download-rustc = "if-unchanged"`) - rust-lang#83705 (Give a better error when --theme is not a CSS file) - rust-lang#83853 (Disallow the use of high byte registes as operands on x86_64) - rust-lang#83877 (Remove unnecessary exceptions to the platform-specific code check) - rust-lang#83878 (Fix racing file access in tidy) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
cc #83478