Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Source Serif to release 4.004 #83650

Merged
merged 2 commits into from
Apr 5, 2021
Merged

Update Source Serif to release 4.004 #83650

merged 2 commits into from
Apr 5, 2021

Conversation

tspiteri
Copy link
Contributor

Now the family name is Source Serif 4 (upstream issue 77) instead of Source Serif Pro.

@rust-highfive
Copy link
Collaborator

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez

@rust-highfive
Copy link
Collaborator

r? @ollie27

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 29, 2021
@tspiteri
Copy link
Contributor Author

The file names have been changed just like in the font upstream release. I believe that thanks to @jyn514 now the docs.rs maintenance burden because of changing file names is reduced (removed?).

@jyn514
Copy link
Member

jyn514 commented Mar 29, 2021

The file names have been changed just like in the font upstream release. I believe that thanks to @jyn514 now the docs.rs maintenance burden because of changing file names is reduced (removed?).

Yes, docs.rs should take of this automatically now: rust-lang/docs.rs#1312

@GuillaumeGomez
Copy link
Member

Just want to confirm one thing before approval: is there any changes in the text rendering?

@jyn514 jyn514 assigned GuillaumeGomez and unassigned ollie27 Apr 4, 2021
@jyn514 jyn514 added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Apr 4, 2021
@tspiteri
Copy link
Contributor Author

tspiteri commented Apr 4, 2021

@GuillaumeGomez From the 4.004 release notes:

Adding optical sizes required re-assessment of spacing, proportions, and kerning decisions in all masters. Additionally, an intermediate master was shifted to clean up the VF design space.
While care was taken to keep the existing styles largely equivalent to previous releases, reflow of existing documents is likely.
The “Pro” label originally was attached to OpenType fonts to indicate their extended language coverage. With Source Serif’s character support far exceeding former “Pro” standards, this label does not have much meaning anymore.

For these reasons, the decision was made to change the family name from Source Serif Pro to Source Serif 4.

This indicates that some documents are likely to get reflow (which can be the case with any tweak in kerning or in metrics), but the existing styles are largely equivalent.

@GuillaumeGomez
Copy link
Member

I guess it's fine then. Thanks!

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Apr 4, 2021

📌 Commit a0bd59e has been approved by GuillaumeGomez

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 4, 2021
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Apr 4, 2021
@Dylan-DPC
Rollup merge of rust-lang#83650 - tspiteri:source-serif-4, r=Guillaum…
39638d1 
…eGomez

Update Source Serif to release 4.004

Now the family name is Source Serif 4 (upstream issue 77) instead of Source Serif Pro.
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Apr 4, 2021
Closed
@Dylan-DPC-zz
Copy link

failed in rollup

@Dylan-DPC-zz
Copy link

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 4, 2021
@tspiteri
Update Source Serif to release 4.004
29fed9a 
Now the family name is Source Serif 4 (upstream issue 77) instead of
Source Serif Pro.
@tspiteri
change SourceSerifPro to SourceSerif4 in emit-shared-files test
70b0874
@tspiteri
Copy link
Contributor Author

tspiteri commented Apr 5, 2021

Rebased and added a commit to change "SourceSerifPro-It.ttf.woff" to "SourceSerif4-It.ttf.woff" in src/test/run-make/emit-shared-files/Makefile which was introduced in #83478.

@jyn514
Copy link
Member

jyn514 commented Apr 5, 2021

@bors r=GuillaumeGomez

@bors
Copy link
Contributor

bors commented Apr 5, 2021

📌 Commit 70b0874 has been approved by GuillaumeGomez

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 5, 2021
jyn514 pushed a commit to jyn514/rust that referenced this pull request Apr 5, 2021
Rollup merge of rust-lang#83650 - tspiteri:source-serif-4, r=Guillaum…
8b56beb 
…eGomez

Update Source Serif to release 4.004

Now the family name is Source Serif 4 (upstream issue 77) instead of Source Serif Pro.
@jyn514 jyn514 mentioned this pull request Apr 5, 2021
Closed
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Apr 5, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 5, 2021
@bors
Auto merge of rust-lang#83880 - Dylan-DPC:rollup-hz9ph0e, r=Dylan-DPC
39eee17 
Rollup of 8 pull requests

Successful merges:

 - rust-lang#81922 (Let `#[allow(unstable_name_collisions)]` work for things other than function)
 - rust-lang#82483 (Use FromStr trait for number option parsing)
 - rust-lang#82739 (Use the beta compiler for building bootstrap tools when `download-rustc` is set)
 - rust-lang#83650 (Update Source Serif to release 4.004)
 - rust-lang#83826 (List trait impls before deref methods in doc's sidebar)
 - rust-lang#83831 (Add `#[inline]` to IpAddr methods)
 - rust-lang#83863 (Render destructured struct function param names as underscore)
 - rust-lang#83865 (Don't report disambiguator error if link would have been ignored)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit ad0a995 into rust-lang:master Apr 5, 2021
@rustbot rustbot added this to the 1.53.0 milestone Apr 5, 2021
@tspiteri tspiteri deleted the source-serif-4 branch April 5, 2021 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@GuillaumeGomez GuillaumeGomez

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.53.0
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@tspiteri @rust-highfive @jyn514 @GuillaumeGomez @bors @Dylan-DPC-zz @ollie27 @rustbot