Convert rustfmt from a submodule to a subtree #82208
Commits on Oct 4, 2019
Commits on Oct 6, 2019
-
Merge pull request rust-lang#3838 from calebcartwright/static-raw-ide…
…nt-prefix add static support for raw prefix identifiers
Commits on Oct 7, 2019
Commits on Oct 8, 2019
Commits on Oct 10, 2019
Commits on Oct 19, 2019
Commits on Oct 24, 2019
Commits on Oct 25, 2019
Commits on Feb 9, 2020
-
-
Backport the fix for the parser bug where the messages from fatal/non-recoverable parser errors were being silently eaten by rustfmt.
-
Commits on Feb 10, 2020
Commits on Mar 27, 2020
Commits on Mar 28, 2020
Commits on Mar 30, 2020
-
-
-
Merge pull request rust-lang#4100 from calebcartwright/rustfmt1x-rust…
…c-v650 bump rustfmt 1x to rustc-ap v651
Commits on Mar 31, 2020
-
backport new syntax to rustfmt 1.x (rust-lang#4105)
* feat: support raw reference operator * feat: support const opt-out syntax * feat: support half open range syntax
-
Commits on May 19, 2020
Commits on Jun 12, 2020
Commits on Jun 13, 2020
-
Merge pull request rust-lang#4253 from calebcartwright/rustfmt-1.4.18
bump rustfmt 1.x rustc-ap* crates to v644
-
Commits on Jun 27, 2020
Commits on Jul 10, 2020
Commits on Jul 21, 2020
Commits on Aug 7, 2020
Commits on Sep 5, 2020
Commits on Oct 2, 2020
-
Preserve and format type aliases in extern blocks
Previously, non-trivial type aliases in extern blocks were dropped by rustfmt because only the type alias name would be passed to a rewritter. This commit fixes that by passing all type information (generics, bounds, and assignments) to a type alias rewritter, and consolidates `rewrite_type_alias` and `rewrite_associated_type` as one function.
-
-
-
Commits on Oct 24, 2020
-
-
-
-
-
Preserve comments in empty statements (rust-lang#4180)
* Preserve comments in empty statements Closes rust-lang#4018 * fixup! Preserve comments in empty statements
-
Fix overriding license header bug (rust-lang#4488)
* Override header to None when path len = 0 * Add regression test * Ensure nightly
Commits on Nov 3, 2020
-
-
-
-
-
-
Add some basic tests for
try{}expressionsThey failed to parse in rustfmt on me in rust-lang#77877, which looks like it's since been fixed, but I figured I'd send in some tests anyway.
-
-
-
Commits on Nov 6, 2020
-
Don't flatten a block containing a single macro call
We no longer flatten a block that looks like this: ```rust match val { pat => { macro_call!() } } ``` Currently, rust ignores trailing semicolons in macro expansion in expression position (see rust-lang#33953) If this is changed, flattening a block with a macro call may break the user's code - the trailing semicolon will no longer parse if the macro call occurs immediately on the right-hand side of the match arm (e.g. `pat => macro_call!()`) -
-
Commits on Nov 14, 2020
-
Correctly create artificial span for formatting closure body
This commit partially reverts rust-lang#3934, opting to create a span that covers the entire body of a closure when formatting a closure body with a block-formatting strategy, rather than having the block-formatting code determine if the visitor pointer should be rewound. The problem with rewinding the visitor pointer is it may be incorrect for other (i.e. non-artificial) AST nodes, as in the case of rust-lang#4382. Closes rust-lang#4382
-
Fixed 'Incorrect comment indent inside if/else' issue. (rust-lang#4459)
* Added test cases * Fixed if condition comment issue * Fixed extern C issue * Removed previous test case * Removed tmp file * honor the authors intent * Changed the file name to its original name * Removed extra whitespace
-
-
-
Commits on Nov 19, 2020
-
Option to create groups for std, external crates, and other imports
Backport of 17d90ca.
Commits on Nov 26, 2020
Commits on Nov 28, 2020
Commits on Nov 29, 2020
-
-
Properly format function signature in extern blocks
Closes rust-lang#4288 And we get to drop a method, which I think is a win :)
-
Don't drop blocks on foreign functions
A code like ```rust extern "C" { fn f() { fn g() {} } } ``` is incorrect and does not compile. Today rustfmt formats this in a way that is correct: ```rust extern "C" { fn f(); } ``` But this loses information, and doesn't have to be done because we know the content of the block if it is present. During development I don't think rustfmt should drop the block in this context. Closes rust-lang#4313 -
-
Compare code block line indentation with config whitespace (rust-lang…
…#4166) Previously the indetation of a line was compared with the configured number of spaces per tab, which could cause lines that were formatted with hard tabs not to be recognized as indented ("\t".len() < " ".len()). Closes rust-lang#4152
-
-
-
-
Pick up comments between visibility modifier and item name (rust-lang…
…#4239) * Pick up comments between visibility modifier and item name I don't think this hurts to fix. rust-lang#2781, which surfaced this issue, has a number of comments relating to similar but slightly different issues (i.e. dropped comments in other places). I can mark rust-lang#2781 as closed and then will open new issues for the comments that are not already resolved or tracked. Closes rust-lang#2781 * fixup! Pick up comments between visibility modifier and item name * fixup! Pick up comments between visibility modifier and item name
-
-
Fixed 'Comment removed between type name and =' issue (rust-lang#4448)
* Fixed Comment removed between type name and = issue * Fixed where clause issue and pass the full span * has_where condition inline * Fixed indentation error on where clause * Removed tmp file
-
Fixed comment dropped between & and type issue (rust-lang#4482)
* Fixed comment dropped between & and type issue * Reduced nesting levels and avoided duplications * Removed extra allocations
-
-
Comment between typebounds (rust-lang#4474)
* Test cases and get spans * Fixed type bounds * Fixed issue of test cases * Fixed first test case issue * Removed unwanted whitespaces * Removed tmp files
-
Commits on Dec 5, 2020
Commits on Dec 20, 2020
-
-
Fix rewrite of closures with a return type
If the closure's body fits in a line, the block is removed but it is necessary if the closure has a return type.
-
Format error and typeof types (rust-lang#4416)
* Add a test for rust-lang#4357 * Format error and typeof types
-
Commits on Jan 9, 2021
Commits on Jan 17, 2021
-
Rename
merge_importstoimports_granularityand add aModuleop……tion. This renames the existing `true`/`false` options to `Crate`/`Never`, then adds a new `Module` option which causes imports to be grouped together by their originating module.
-
Commits on Jan 28, 2021
-
-
-
Add imports_granularity="Item".
This option splits all imports into their own `use` statement.
-
-
-
-
Commits on Jan 29, 2021
Commits on Feb 4, 2021
-
Add arch name to archive files created in the upload workflow (rust-l…
…ang#4679) * Add arch name to archive files created in the upload workflow * Fix arch names in matrix.build key to include arch name as well
-
-
-
-
Commits on Feb 13, 2021
Commits on Feb 18, 2021
-
- Fix nightly warning about `format!` - Remove unused functions and fields
-
Commits on Feb 19, 2021
-
This commit can be replicated with `cargo clippy --fix -Z unstable-options && cargo +nightly-2021-02-10 fmt`.
Commits on Mar 19, 2021
Commits on Apr 3, 2021
Commits on Apr 22, 2021
-
Don't show CRLF tests as modified in the working directory
This was being overriden by `lf=eof` in `.gitattributes` in the root directory. Override it again to avoid warnings like this: ``` $ git diff src/tools/rustfmt/tests/target/issue-3494/crlf.rs warning: CRLF will be replaced by LF in src/tools/rustfmt/tests/target/issue-3494/crlf.rs. The file will have its original line endings in your working directory ```
-
Use
rustc_privateinstead of crates.io dependencies- Update rust-toolchain to also install `rustc-dev` component
-
-
Use rustup in CI to automatically determine the toolchain version needed
This also removes the (now unused) `RUSTC_RELEASE` and `RUSTC_RELEASE_CHANNEL` variables.
-
-
-
-
-
-
-
Commits on May 2, 2021
Commits on May 4, 2021
Commits on May 14, 2021
Commits on May 15, 2021
-
-
-
Add 'src/tools/rustfmt/' from commit '7872306edf2e11a69aaffb9434088fd…
-
Update bootstrap for in-tree rustfmt
- Add rustfmt to `x.py check` - Update Cargo.lock - Remove rustfmt from the toolstate list - Make rustfmt an in-tree tool - Give an error on `x.py test rustfmt` if rustfmt fails to build or if tests fail - Don't call `save_toolstate` when testing rustfmt
-
Don't copy tool dependencies to the sysroot
This fixes the following error: ``` error: found crates (`serde_derive` and `serde_derive`) with colliding StableCrateId values. --> /home/joshua/.local/lib/cargo/registry/src/github.com-1ecc6299db9ec823/cargo_metadata-0.8.2/src/lib.rs:162:1 | 162 | extern crate serde_derive; | ^^^^^^^^^^^^^^^^^^^^^^^^^^ ``` This is a bug in resolve (rust-lang#56935) but it will be difficult to fix in the near future. This works around it in the meantime by not copying serde_derive and other dependencies to the sysroot when they're built for other tools. This rebuilds the dependencies slightly more often than necessary, but avoids the crate conflicts. This can be reverted once rust-lang#56935 is fixed. -
This avoids the following warning: ``` warning: trailing semicolon in macro used in expression position --> /home/joshua/.local/lib/cargo/registry/src/github.com-1ecc6299db9ec823/log-0.4.11/src/macros.rs:152:45 | 147 | / macro_rules! debug { 148 | | (target: $target:expr, $($arg:tt)+) => ( 149 | | log!(target: $target, $crate::Level::Debug, $($arg)+); 150 | | ); 151 | | ($($arg:tt)+) => ( 152 | | log!($crate::Level::Debug, $($arg)+); | | ^ 153 | | ) 154 | | } | |_- in this expansion of `debug!` | ::: src/tools/rustfmt/src/modules/visitor.rs:36:23 | 36 | Err(e) => debug!("{}", e), | --------------- in this macro invocation | = note: requested on the command line with `-W semicolon-in-expressions-from-macros` = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! = note: for more information, see issue rust-lang#79813 <rust-lang#79813> ``` -
Run toolstate jobs when src/tools/rustfmt is modified.
Previously, this would be caught by a change for modified submodules; now that rustfmt is no longer a submodule, the check needs to be explicit.
-
should-skip-this: Check for changes between the master branch, not th…
…e previous commit. The previous commit could be part of the current PR.