Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Token-based outer attributes handling #76130

Closed
wants to merge 6 commits into from
Closed

[WIP] Token-based outer attributes handling #76130

wants to merge 6 commits into from

Commits on Sep 24, 2020

  1. Introduce PreexpTokenStream

    @Aaron1011
    Aaron1011 committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    ae0b317 View commit details
    Browse the repository at this point in the history

  2. Only collect tokens for attributes themselves when needed 

    We need attribute tokens if the target supports custom attributes, or we
are inside a `derive` target. Otherwise, we don't need tokens for
individual tokens - any needed token collection will be handled further
up the stack.
    @Aaron1011
    Aaron1011 committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    6b8bf20 View commit details
    Browse the repository at this point in the history

  3. Include comma in tuple struct/enum field

    @Aaron1011
    Aaron1011 committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    bf36dfb View commit details
    Browse the repository at this point in the history

  4. Revert "Only collect tokens for attributes themselves when needed" 

    The perf run didn't show any improvement, and this added a lot of
additional complexity.

This reverts commit 6b8bf20.
    @Aaron1011
    Aaron1011 committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    81e7d5b View commit details
    Browse the repository at this point in the history

  5. Don't overwrite existing tokens when parsing Stmt

    @Aaron1011
    Aaron1011 committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    d8b950b View commit details
    Browse the repository at this point in the history

  6. Some cleanup

    @Aaron1011
    Aaron1011 committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    d03976c View commit details
    Browse the repository at this point in the history