Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 11 pull requests #62840

Closed
wants to merge 28 commits into from
Closed

Conversation

Centril
Copy link
Contributor

@Centril Centril commented Jul 21, 2019

Successful merges:

Failed merges:

r? @ghost

nhynes and others added 28 commits July 16, 2019 02:34
Given

```
mented on Jan 26, 2015 •
 trait Foo { fn method(&self) {} }

fn call_method<T>(x: &T) {
    x.method()
}
```

suggest constraining `T` with `Foo`.
Affect is usually used as a verb, effect as a verb.
I think this was left out by accident from the "convert everything to
rlibs" commit, there's no need for this to be a dylib just as everything
else doesn't need to be a dylib!
…iper

Test that maplike FromIter satisfies uniqueness

This PR adds a simple assertion to the `HashMap` and `HashSet` tests to ensure that uniqueness is satisfied when `FromIter`ing. This is useful for people who want to test their custom type against the Map/Set interfaces since they'll copy the tests wholesale but possibly miss this bug (where _they_ = _me_).
Suggest trait bound on type parameter when it is unconstrained

Given

```
trait Foo { fn method(&self) {} }

fn call_method<T>(x: &T) {
    x.method()
}
```

suggest constraining `T` with `Foo`.

Fix rust-lang#21673, fix rust-lang#41030.
Fix typo in src/libstd/net/udp.rs doc comment

Affect is usually used as a verb, effect as a verb.
…_compiler_messages_p9, r=Centril

normalize use of backticks in compiler messages for libcore/ptr

rust-lang#60532
… r=eddyb

rustc_typeck: improve diagnostics for _ const/static declarations

This continues rust-lang#62694 and adds type suggestions to const/static declarations with `_` type.

r? @eddyb
Revert "Disable stack probing for gnux32."

This reverts commit 42d652e. (rust-lang#59686)

Closes rust-lang#59674.
…_compiler_messages_p11, r=GuillaumeGomez

normalize use of backticks in compiler messages for librustc_metadata

rust-lang#60532
…ulacrum

rustc: Compile the `fmt_macros` crate as an rlib

I think this was left out by accident from the "convert everything to
rlibs" commit, there's no need for this to be a dylib just as everything
else doesn't need to be a dylib!
…_compiler_messages_p12, r=Centril

normalize use of backticks in compiler messages for librustc_incremental

rust-lang#60532
@Centril
Copy link
Contributor Author

Centril commented Jul 21, 2019

@bors r+ p=11 rollup=never

@bors
Copy link
Contributor

bors commented Jul 21, 2019

📌 Commit 6558b98 has been approved by Centril

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jul 21, 2019
@bors
Copy link
Contributor

bors commented Jul 21, 2019

⌛ Testing commit 6558b98 with merge fd584a066edde978d593300b0918dfa700e9c531...

@bors
Copy link
Contributor

bors commented Jul 21, 2019

💔 Test failed - checks-azure

@rust-highfive
Copy link
Collaborator

Your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-07-21T07:05:33.5721986Z do so (now or later) by using -b with the checkout command again. Example:
2019-07-21T07:05:33.5722040Z 
2019-07-21T07:05:33.5722323Z   git checkout -b <new-branch-name>
2019-07-21T07:05:33.5722370Z 
2019-07-21T07:05:33.5722683Z HEAD is now at fd584a066 Auto merge of #62840 - Centril:rollup-5ettkjy, r=Centril
2019-07-21T07:05:33.5875289Z ##[section]Starting: Collect CPU-usage statistics in the background
2019-07-21T07:05:33.5879069Z ==============================================================================
2019-07-21T07:05:33.5879164Z Task         : Bash
2019-07-21T07:05:33.5879248Z Description  : Run a Bash script on macOS, Linux, or Windows
---
2019-07-21T07:08:55.3050814Z Script contents:
2019-07-21T07:08:55.3051445Z aws s3 cp --acl public-read cpu-usage.csv s3://$DEPLOY_BUCKET/rustc-builds/$BUILD_SOURCEVERSION/cpu-$SYSTEM_JOBNAME.csv
2019-07-21T07:08:55.3071268Z ========================== Starting Command Output ===========================
2019-07-21T07:08:55.3092118Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/fc63736e-cfb2-44ae-a9f2-7c0cd287aa91.sh
2019-07-21T07:08:55.3186915Z /home/vsts/work/_temp/fc63736e-cfb2-44ae-a9f2-7c0cd287aa91.sh: line 1: aws: command not found
2019-07-21T07:08:55.3222103Z ##[error]Bash exited with code '127'.
2019-07-21T07:08:55.3255938Z ##[section]Starting: Checkout
2019-07-21T07:08:55.3257759Z ==============================================================================
2019-07-21T07:08:55.3257847Z Task         : Get sources
2019-07-21T07:08:55.3257948Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 21, 2019
@Centril Centril closed this Jul 21, 2019
@Centril Centril deleted the rollup-5ettkjy branch July 21, 2019 14:17
@Centril Centril added the rollup A PR which is a rollup label Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollup A PR which is a rollup S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants