Reduce reliance on await!(...) macro
#62324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
|
r=me with rebase (and once the async closures change merges, since this is based on that) |
Centril
force-pushed
the
reduce-await-macro-reliance
branch
from
62725b6
to
3eef0cb
Compare
|
📌 Commit 3eef0cb has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jul 4, 2019
…, r=cramertj Reduce reliance on `await!(...)` macro Only the last commit is new. r? @cramertj
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jul 4, 2019
…, r=cramertj Reduce reliance on `await!(...)` macro Only the last commit is new. r? @cramertj
eddyb
reviewed
Jul 4, 2019
| "`let` expressions in this position are experimental" | ||
| )); | ||
|
|
||
| for_each_in_lock(&sess.async_closure_spans, |span| gate_feature!( |
There was a problem hiding this comment.
It's terser and has less repetition this way and I don't really fancy for loops since they invite using break and continue which seems preferable to avoid if possible in favor of a more functional-ish approach.
Mark-Simulacrum
added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
Jul 4, 2019
…, r=cramertj Reduce reliance on `await!(...)` macro Only the last commit is new. r? @cramertj
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jul 5, 2019
…, r=cramertj Reduce reliance on `await!(...)` macro Only the last commit is new. r? @cramertj
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jul 5, 2019
…, r=cramertj Reduce reliance on `await!(...)` macro Only the last commit is new. r? @cramertj
bors
added a commit
that referenced
this pull request
Jul 5, 2019
Rollup of 10 pull requests Successful merges: - #62123 ( Remove needless lifetimes (std)) - #62150 (Implement mem::{zeroed,uninitialized} in terms of MaybeUninit.) - #62169 (Derive which queries to save using the proc macro) - #62238 (Fix code block information icon position) - #62292 (Move `async || ...` closures into `#![feature(async_closure)]`) - #62323 (Clarify unaligned fields in ptr::{read,write}_unaligned) - #62324 (Reduce reliance on `await!(...)` macro) - #62371 (Add tracking issue for Box::into_pin) - #62383 (Improve error span for async type inference error) - #62388 (Break out of the correct number of scopes in loops) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only the last commit is new.
r? @cramertj