Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand suggestions for type ascription parse errors #59150

Merged
merged 6 commits into from
Mar 26, 2019
Merged

Expand suggestions for type ascription parse errors #59150

merged 6 commits into from
Mar 26, 2019

Commits on Mar 23, 2019

  1. Expand suggestions for type ascription parse errors

    @estebank
    estebank committed Mar 23, 2019
    Configuration menu
    Copy the full SHA
    8ba1a97 View commit details
    Browse the repository at this point in the history

  2. Tweak labels

    @estebank
    estebank committed Mar 23, 2019
    Configuration menu
    Copy the full SHA
    b1a6c32 View commit details
    Browse the repository at this point in the history

  3. Only suggest let assignment for type ascription if we find an equals … 

    …sign
    @estebank
    estebank committed Mar 23, 2019
    Configuration menu
    Copy the full SHA
    72a3089 View commit details
    Browse the repository at this point in the history

  4. Hide "type ascription is experimental error" unless it's the only one 

    In order to minimize the verbosity of common syntax errors that are parsed
as type ascription, hide the feature gate error unless there are no other
errors being emitted by the parser.
    @estebank
    estebank committed Mar 23, 2019
    Configuration menu
    Copy the full SHA
    81b876b View commit details
    Browse the repository at this point in the history

  5. Review comment

    @estebank
    estebank committed Mar 23, 2019
    Configuration menu
    Copy the full SHA
    44a086e View commit details
    Browse the repository at this point in the history

  6. Reword type ascription note to reduce verbosity

    @estebank
    estebank committed Mar 23, 2019
    Configuration menu
    Copy the full SHA
    d72ef21 View commit details
    Browse the repository at this point in the history