Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Destabilize fixed-width const defined atomic integers #58616

Merged
merged 1 commit into from
Feb 22, 2019
Merged

Destabilize fixed-width const defined atomic integers #58616

merged 1 commit into from
Feb 22, 2019

Conversation

vertexclique
Copy link
Member

@vertexclique vertexclique commented Feb 21, 2019 •
edited by Centril

With this PR version 1.34.0 onwards const declarations of atomic integers will be unstable.

@vertexclique
Destabilize fixed-width const defined atomic integers
99d67ca 
* With this PR 1.34.0 onwards const declarations of atomic integers will be
  unstable.
@rust-highfive
Copy link
Collaborator

r? @dtolnay

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 21, 2019
@Centril
Copy link
Contributor

Centril commented Feb 21, 2019

@bors p=50

dtolnay
dtolnay approved these changes Feb 21, 2019
View reviewed changes
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me. I confirmed that the three existing stable consts as of rustc 1.33.0-beta, ATOMIC_BOOL_INIT, ATOMIC_ISIZE_INIT, ATOMIC_USIZE_INIT continue to be stable (but deprecated) with this PR, while the unstable as of rustc 1.33.0-beta consts are being reverted to unstable.

@dtolnay
Copy link
Member

dtolnay commented Feb 21, 2019

@bors r+

@bors
Copy link
Contributor

bors commented Feb 21, 2019

📌 Commit 99d67ca has been approved by dtolnay

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 21, 2019
@bors
Copy link
Contributor

bors commented Feb 21, 2019

⌛ Testing commit 99d67ca with merge 822c2262217f7f34e049930d557af72fc735d731...

@Centril
Copy link
Contributor

Centril commented Feb 21, 2019

@bors retry

@rust-highfive
Copy link
Collaborator

Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
Cloning into 'rust-lang/rust'...
travis_time:end:06e6e2c6:start=1550782468421553257,finish=1550782474462258704,duration=6040705447
$ cd rust-lang/rust
$ git checkout -qf 822c2262217f7f34e049930d557af72fc735d731
fatal: reference is not a tree: 822c2262217f7f34e049930d557af72fc735d731
The command "git checkout -qf 822c2262217f7f34e049930d557af72fc735d731" failed and exited with 128 during .
Your build has been stopped.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@scottmcm
Copy link
Member

Awesome, thanks @vertexclique! Great that this is getting in in time so we don't add debt.

@vertexclique
Copy link
Member Author

Aye! Better together folks!

@bors
Copy link
Contributor

bors commented Feb 21, 2019

⌛ Testing commit 99d67ca with merge 4de13991d613e2cb81717bc66591916c93553622...

@Centril
Copy link
Contributor

Centril commented Feb 21, 2019

@bors retry

@Centril
Copy link
Contributor

Centril commented Feb 22, 2019

@bors treeclosed-

@bors
Copy link
Contributor

bors commented Feb 22, 2019

⌛ Testing commit 99d67ca with merge d1f8970...

bors added a commit that referenced this pull request Feb 22, 2019
@bors
Auto merge of #58616 - vertexclique:destabilize-fixed-width-atomic-in…
d1f8970 
…tegers, r=dtolnay

Destabilize fixed-width const defined atomic integers

With this PR version 1.34.0 onwards const declarations of atomic integers will be unstable.

* Closes #58089
* Reverts partially: #57425
@bors
Copy link
Contributor

bors commented Feb 22, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: dtolnay
Pushing d1f8970 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 22, 2019
@bors
Copy link
Contributor

bors commented Feb 22, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: dtolnay
Pushing d1f8970 to master...

@bors bors merged commit 99d67ca into rust-lang:master Feb 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtolnay dtolnay dtolnay approved these changes

Assignees

@dtolnay dtolnay

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@vertexclique @rust-highfive @Centril @dtolnay @bors @scottmcm