Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustc_typeck: turn where Type:, into a WF(Type) predicate, instead of ignoring it. #53707

Merged
merged 1 commit into from
Sep 6, 2018
Merged

rustc_typeck: turn where Type:, into a WF(Type) predicate, instead of ignoring it. #53707

merged 1 commit into from
Sep 6, 2018

Conversation

eddyb
Copy link
Member

@eddyb eddyb commented Aug 25, 2018 •
edited

Fixes #53696, assuming crater doesn't catch anyone using this syntax already.

Allowing an empty list of bounds in the grammar was done for the benefit of macro authors, most of which would probably be using it for bounds on type parameters, which are always WF.

r? @nikomatsakis cc @petrochenkov

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 25, 2018
@eddyb
Copy link
Member Author

eddyb commented Aug 25, 2018

@bors try

cc @Mark-Simulacrum @kennytm Can we do a check-only crater run? I hope it's quick.

@bors
Copy link
Contributor

bors commented Aug 25, 2018

⌛ Trying commit e7cab97 with merge 240bd89...

bors added a commit that referenced this pull request Aug 25, 2018
@bors
Auto merge of #53707 - eddyb:phantom-waffles, r=<try>
240bd89 
rustc_typeck: turn `where Type:,` into a WF(Type) predicate, instead of ignoring it.

Fixes #53696, assuming crater doesn't catch anyone using this syntax already.

r? @nikomatsakis cc @petrochenkov
@rust-highfive

This comment has been minimized.

Sign in to view
@bors

This comment has been minimized.

Sign in to view
@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 25, 2018
@rust-highfive

This comment has been minimized.

Sign in to view
@eddyb

This comment has been minimized.

Sign in to view
@eddyb
Copy link
Member Author

eddyb commented Aug 26, 2018

@bors try

@bors
Copy link
Contributor

bors commented Aug 26, 2018

⌛ Trying commit 5726f6a6c281314797db291ab2cb7888d34734da with merge ba5d69382742f59ab9246cec0650adddabfe6818...

@bors
Copy link
Contributor

bors commented Aug 26, 2018

💔 Test failed - status-travis

@rust-highfive
Copy link
Collaborator

The job dist-x86_64-linux of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
travis_fold:end:services

travis_fold:start:git.checkout
travis_time:start:004540de
$ git clone --depth=2 --branch=try https://github.com/rust-lang/rust.git rust-lang/rust

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@eddyb
Copy link
Member Author

eddyb commented Aug 26, 2018

I've very confused, how did it manage to time out while building LLVM?

@eddyb
Copy link
Member Author

eddyb commented Aug 26, 2018

@bors try

@bors
Copy link
Contributor

bors commented Aug 26, 2018

⌛ Trying commit 93b345a7f4299243280a9ad88fa9e5c0d8fb2991 with merge 2d477f9981361618ac78253c28051a66b6cea125...

@bors
Copy link
Contributor

bors commented Aug 26, 2018

☀️ Test successful - status-travis
State: approved= try=True

@pietroalbini
Copy link
Member

@craterbot run start=master#ede55518431154bc761f7b2438cce9078c162700 end=try#2d477f9981361618ac78253c28051a66b6cea125 mode=check-only

@craterbot
Copy link
Collaborator

👌 Experiment pr-53707 created and queued.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 26, 2018
nikomatsakis
nikomatsakis approved these changes Aug 27, 2018
View reviewed changes
Copy link
Contributor

@nikomatsakis nikomatsakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code seems reasonable.

@craterbot
Copy link
Collaborator

🚧 Experiment pr-53707 is now running on agent crater-2.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🎉 Experiment pr-53707 is completed!
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Aug 31, 2018
@eddyb
Copy link
Member Author

eddyb commented Aug 31, 2018

@nikomatsakis Looks like crater had no regressions, r?

@eddyb eddyb mentioned this pull request Sep 5, 2018
Closed
@oli-obk
Copy link
Contributor

oli-obk commented Sep 5, 2018

@bors r+

@bors
Copy link
Contributor

bors commented Sep 5, 2018

📌 Commit 6b8fba5 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 5, 2018
@bors
Copy link
Contributor

bors commented Sep 6, 2018

⌛ Testing commit 6b8fba5 with merge 8fbd378d35b045b23a49a545b4c5934618e7bf59...

@bors
Copy link
Contributor

bors commented Sep 6, 2018

💔 Test failed - status-travis

@rust-highfive
Copy link
Collaborator

The job dist-x86_64-linux of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
travis_time:end:27e4a053:start=1536216084083838303,finish=1536216084096498265,duration=12659962
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:0ff58968
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:12b719ec
travis_time:start:12b719ec
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:187392e4
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 6, 2018
@kennytm
Copy link
Member

kennytm commented Sep 6, 2018

@bors retry travis-ci/travis-ci#9696

[01:37:57] curl: (6) Couldn't resolve host 's3-us-west-1.amazonaws.com'
[01:38:37] curl: (6) Couldn't resolve host 's3-us-west-1.amazonaws.com'
[01:39:17] curl: (6) Couldn't resolve host 's3-us-west-1.amazonaws.com'
[01:39:17] thread 'main' panicked at 'failed to download openssl source: exit code: 6', bootstrap/native.rs:612:17

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 6, 2018
@bors
Copy link
Contributor

bors commented Sep 6, 2018

⌛ Testing commit 6b8fba5 with merge 35a5541...

bors added a commit that referenced this pull request Sep 6, 2018
@bors
Auto merge of #53707 - eddyb:phantom-waffles, r=oli-obk
35a5541 
rustc_typeck: turn `where Type:,` into a WF(Type) predicate, instead of ignoring it.

Fixes #53696, assuming crater doesn't catch anyone using this syntax already.

Allowing an empty list of bounds in the grammar was done for the benefit of macro authors, most of which would *probably* be using it for bounds on type parameters, which are always WF.

r? @nikomatsakis cc @petrochenkov
@bors
Copy link
Contributor

bors commented Sep 6, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: oli-obk
Pushing 35a5541 to master...

@bors bors merged commit 6b8fba5 into rust-lang:master Sep 6, 2018
@eddyb eddyb deleted the phantom-waffles branch September 6, 2018 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikomatsakis nikomatsakis nikomatsakis approved these changes

Assignees

@nikomatsakis nikomatsakis

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@eddyb @bors @rust-highfive @pietroalbini @craterbot @oli-obk @kennytm @nikomatsakis