Fix the dedup error because of spans from suggestion #125135
Merged
+47
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenyukang
force-pushed
the
yukang-fix-116502
branch
from
44fb4db
to
75895f5
Compare
rustbot
added
T-compiler
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 15, 2024
…iaskrgr Rollup of 4 pull requests Successful merges: - rust-lang#124990 (Also expand weak alias tys inside consts inside `expand_weak_alias_tys`) - rust-lang#125108 (coverage: `CoverageIdsInfo::mcdc_bitmap_bytes` is never needed) - rust-lang#125132 (Add `on_unimplemented" typo suggestions) - rust-lang#125135 (Fix the dedup error because of spans from suggestion) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 15, 2024
Rollup merge of rust-lang#125135 - chenyukang:yukang-fix-116502, r=compiler-errors Fix the dedup error because of spans from suggestion Fixes rust-lang#116502 I believe this kind of issue is supposed resolved by rust-lang#118057, but the `==` in `span` respect syntax context, here we should only care that they point to the same bytes of source text, so should use `source_equal`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #116502
I believe this kind of issue is supposed resolved by #118057, but the
==inspanrespect syntax context, here we should only care that they point to the same bytes of source text, so should usesource_equal.