Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add `on_unimplemented" typo suggestions #125132

Merged
merged 1 commit into from
May 15, 2024
Merged

Add `on_unimplemented" typo suggestions #125132

merged 1 commit into from
May 15, 2024

Conversation

mejrs
Copy link
Contributor

@mejrs mejrs commented May 14, 2024

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented May 14, 2024

r? @oli-obk

rustbot has assigned @oli-obk.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 14, 2024
@rust-log-analyzer

This comment has been minimized.

Sign in to view
compiler-errors
compiler-errors approved these changes May 15, 2024
View reviewed changes
Copy link
Member

@compiler-errors compiler-errors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆒

I'd like to see this generalized for an arbitrary set of diagnostic attrs, but that can be done later when adding a new diagnostic attr (cc @weiznich who is adding diagnostic::do_not_recommend).

@compiler-errors
Copy link
Member

r? compiler-errors @bors r+ rollup

@bors
Copy link
Contributor

bors commented May 15, 2024

📌 Commit 18d7411 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 15, 2024
@matthiaskrgr matthiaskrgr mentioned this pull request May 15, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 15, 2024
@bors
Auto merge of rust-lang#125136 - matthiaskrgr:rollup-ljm15m3, r=matth…
44fa5fd 
…iaskrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#124990 (Also expand weak alias tys inside consts inside `expand_weak_alias_tys`)
 - rust-lang#125108 (coverage: `CoverageIdsInfo::mcdc_bitmap_bytes` is never needed)
 - rust-lang#125132 (Add `on_unimplemented" typo suggestions)
 - rust-lang#125135 (Fix the dedup error because of spans from suggestion)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit f7c2934 into rust-lang:master May 15, 2024
6 checks passed
@rustbot rustbot added this to the 1.80.0 milestone May 15, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request May 15, 2024
@rust-timer
Unrolled build for rust-lang#125132
92b33d0 
Rollup merge of rust-lang#125132 - mejrs:diag, r=compiler-errors

Add `on_unimplemented" typo suggestions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compiler-errors compiler-errors compiler-errors approved these changes

Assignees

@compiler-errors compiler-errors

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.80.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mejrs @rustbot @rust-log-analyzer @compiler-errors @bors @oli-obk