Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make std::env::{set_var, remove_var} unsafe in edition 2024 #124636

Merged
merged 4 commits into from
May 30, 2024
Merged

Make std::env::{set_var, remove_var} unsafe in edition 2024 #124636

merged 4 commits into from
May 30, 2024
+366 −74

Commits on May 29, 2024

  1. Make std::env::{set_var, remove_var} unsafe in edition 2024 

    Allow calling these functions without `unsafe` blocks in editions up
until 2021, but don't trigger the `unused_unsafe` lint for `unsafe`
blocks containing these functions.

Fixes rust-lang#27970.
Fixes rust-lang#90308.
CC rust-lang#124866.
    @tbu-
    tbu- committed May 29, 2024
    Configuration menu
    Copy the full SHA
    5d8f9b4 View commit details
    Browse the repository at this point in the history

  2. Add note about safety of std::env::set_var on Windows

    @tbu-
    tbu- committed May 29, 2024
    Configuration menu
    Copy the full SHA
    8cf4980 View commit details
    Browse the repository at this point in the history

  3. Elaborate about modifying env vars in multi-threaded programs

    @tbu-
    tbu- committed May 29, 2024
    Configuration menu
    Copy the full SHA
    d7680e3 View commit details
    Browse the repository at this point in the history

  4. Add deprecated_safe lint 

    It warns about usages of `std::env::{set_var, remove_var}` with an
automatic fix wrapping the call in an `unsafe` block.
    @tbu-
    tbu- committed May 29, 2024
    Configuration menu
    Copy the full SHA
    44f9f8b View commit details
    Browse the repository at this point in the history