Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change SIGPIPE ui from #[unix_sigpipe = "..."] to -Zon-broken-pipe=... #124480

Merged
merged 1 commit into from
May 4, 2024

Commits on May 2, 2024

  1. Change SIGPIPE ui from #[unix_sigpipe = "..."] to `-Zon-broken-pi…

    …pe=...`
    
    In the stabilization attempt of `#[unix_sigpipe = "sig_dfl"]`, a concern
    was raised related to using a language attribute for the feature: Long
    term, we want `fn lang_start()` to be definable by any crate, not just
    libstd. Having a special language attribute in that case becomes
    awkward.
    
    So as a first step towards towards the next stabilization attempt, this
    PR changes the `#[unix_sigpipe = "..."]` attribute to a compiler flag
    `-Zon-broken-pipe=...` to remove that concern, since now the language
    is not "contaminated" by this feature.
    
    Another point was also raised, namely that the ui should not leak
    **how** it does things, but rather what the **end effect** is. The new
    flag uses the proposed naming. This is of course something that can be
    iterated on further before stabilization.
    Enselic committed May 2, 2024
    Configuration menu
    Copy the full SHA
    cde0cde View commit details
    Browse the repository at this point in the history