Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test 2 #121921

Closed
wants to merge 12 commits into from
Closed

Test 2 #121921

wants to merge 12 commits into from

Conversation

Blakezulla
Copy link

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Mar 3, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 3, 2024
@rustbot
Copy link
Collaborator

rustbot commented Mar 3, 2024

There are merge commits (commits with multiple parents) in your changes. We have a no merge policy so these commits will need to be removed for this pull request to be merged.

You can start a rebase with the following commands:

$ # rebase
$ git rebase -i master
$ # delete any merge commits in the editor that appears
$ git push --force-with-lease

The following commits are merge commits:

@rustbot rustbot added has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 3, 2024
dependabot bot and others added 2 commits March 2, 2024 20:20
Bumps [rustix](https://github.com/bytecodealliance/rustix) from 0.38.8 to 0.38.31.
- [Release notes](https://github.com/bytecodealliance/rustix/releases)
- [Commits](bytecodealliance/rustix@v0.38.8...v0.38.31)

---
updated-dependencies:
- dependency-name: rustix
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
@slanterns
Copy link
Contributor

Hi, can you explain more about how your pull request is related to this project?

Copy link
Author

@Blakezulla Blakezulla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

…_codegen_gcc/rustix-0.38.31

Bump rustix from 0.38.8 to 0.38.31 in /compiler/rustc_codegen_gcc
@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Mar 3, 2024
@rustbot
Copy link
Collaborator

rustbot commented Mar 3, 2024

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo, @GuillaumeGomez

@rustbot
Copy link
Collaborator

rustbot commented Mar 3, 2024

There are merge commits (commits with multiple parents) in your changes. We have a no merge policy so these commits will need to be removed for this pull request to be merged.

You can start a rebase with the following commands:

$ # rebase
$ git rebase -i master
$ # delete any merge commits in the editor that appears
$ git push --force-with-lease

The following commits are merge commits (since this message was last posted):

Signed-off-by: Bakezulla <blakpeters@gmail.com>
@slanterns
Copy link
Contributor

Please stop PR spamming like this. It's a harassment to other maintainers.

@Blakezulla
Copy link
Author

Blakezulla commented Mar 3, 2024 via email

@fee1-dead fee1-dead closed this Mar 3, 2024
Copy link
Author

@Blakezulla Blakezulla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I apologize for the overload. It did help me figure a lot out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants