Make unsized casts illegal #116056
Merged
Make unsized casts illegal #116056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
| @@ -725,6 +725,9 @@ impl<'a, 'tcx> CastCheck<'tcx> { | |||
| }, | |||
| // array-ptr-cast | |||
| Ptr(mt) => { | |||
| if !mt.ty.is_sized(fcx.tcx, fcx.param_env) { | |||
There was a problem hiding this comment.
This type may have region variables. That'll cause an ICE. Try using:
Suggested change
| if !mt.ty.is_sized(fcx.tcx, fcx.param_env) { | |
| if !fcx.type_is_sized_modulo_regions(fcx.param_env, mt.ty) { |
There was a problem hiding this comment.
Thanks! Didn't know this.
|
please squash this into one commit |
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 22, 2023
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#115770 (Match on elem first while building move paths) - rust-lang#115999 (Capture scrutinee of if let guards correctly) - rust-lang#116056 (Make unsized casts illegal) - rust-lang#116061 (Remove TaKO8Ki from review rotation) - rust-lang#116062 (Change `start` to `#[start]` in some diagnosis) - rust-lang#116067 (Open the FileEncoder file for reading and writing) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 22, 2023
Rollup merge of rust-lang#116056 - ouz-a:wide_ice, r=compiler-errors Make unsized casts illegal Weirdly enough this rust-lang#115998 issue seems to exist since Rust 1.0 (couldn't check before that) but it's only recently been noticed. This change makes those casts illegal. Fixes rust-lang#115998
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Weirdly enough this #115998 issue seems to exist since Rust 1.0 (couldn't check before that) but it's only recently been noticed. This change makes those casts illegal.
Fixes #115998