Add arm64e-apple-ios & arm64e-apple-darwin targets #115526

arttet · 2023-09-04T08:18:25Z

This introduces

arm64e-apple-ios
arm64e-apple-darwin

Rust targets for support arm64e architecture on iOS and Darwin.

So, this is a first approach for integrating to the Rust compiler.

Tier 3 Target Policy

A tier 3 target must have a designated developer or developers (the "target
maintainers") on record to be CCed when issues arise regarding the target.
(The mechanism to track and CC such developers may evolve over time.)

I will be the target maintainer.

Targets must use naming consistent with any existing targets; for instance, a
target for the same CPU or OS as an existing Rust target should use the same
name for that CPU or OS. Targets should normally use the same names and
naming conventions as used elsewhere in the broader ecosystem beyond Rust
(such as in other toolchains), unless they have a very good reason to
diverge. Changing the name of a target can be highly disruptive, especially
once the target reaches a higher tier, so getting the name right is important
even for a tier 3 target.
Target names should not introduce undue confusion or ambiguity unless
absolutely necessary to maintain ecosystem compatibility. For example, if
the name of the target makes people extremely likely to form incorrect
beliefs about what it targets, the name should be changed or augmented to
disambiguate it.
If possible, use only letters, numbers, dashes and underscores for the name.
Periods (.) are known to cause issues in Cargo.

The target names arm64e-apple-ios, arm64e-apple-darwin were derived from aarch64-apple-ios, aarch64-apple-darwin.
In this ticket, people discussed the best suitable names for these targets.

In some cases, the arm64e arch might be "different". For example:

thread_set_state might fail with (os/kern) protection failure if we try to call it from arm64 process to arm64e process.

The returning value of dlsym is PAC signed on arm64e, while left untouched on arm64

Some function like pthread_create_from_mach_thread requires a PAC signed function pointer on arm64e, which is not required on arm64.

So, I have chosen them because there are similar triplets in LLVM. I think there are no more suitable names for these targets.

Tier 3 targets may have unusual requirements to build or use, but must not
create legal issues or impose onerous legal terms for the Rust project or for
Rust developers or users.
The target must not introduce license incompatibilities.
Anything added to the Rust repository must be under the standard Rust
license (MIT OR Apache-2.0).
The target must not cause the Rust tools or libraries built for any other
host (even when supporting cross-compilation to the target) to depend
on any new dependency less permissive than the Rust licensing policy. This
applies whether the dependency is a Rust crate that would require adding
new license exceptions (as specified by the tidy tool in the
rust-lang/rust repository), or whether the dependency is a native library
or binary. In other words, the introduction of the target must not cause a
user installing or running a version of Rust or the Rust tools to be
subject to any new license requirements.
Compiling, linking, and emitting functional binaries, libraries, or other
code for the target (whether hosted on the target itself or cross-compiling
from another target) must not depend on proprietary (non-FOSS) libraries.
Host tools built for the target itself may depend on the ordinary runtime
libraries supplied by the platform and commonly used by other applications
built for the target, but those libraries must not be required for code
generation for the target; cross-compilation to the target must not require
such libraries at all. For instance, rustc built for the target may
depend on a common proprietary C runtime library or console output library,
but must not depend on a proprietary code generation library or code
optimization library. Rust's license permits such combinations, but the
Rust project has no interest in maintaining such combinations within the
scope of Rust itself, even at tier 3.
"onerous" here is an intentionally subjective term. At a minimum, "onerous"
legal/licensing terms include but are not limited to: non-disclosure
requirements, non-compete requirements, contributor license agreements
(CLAs) or equivalent, "non-commercial"/"research-only"/etc terms,
requirements conditional on the employer or employment of any particular
Rust developers, revocable terms, any requirements that create liability
for the Rust project or its developers or users, or any requirements that
adversely affect the livelihood or prospects of the Rust project or its
developers or users.

No dependencies were added to Rust.

Neither this policy nor any decisions made regarding targets shall create any
binding agreement or estoppel by any party. If any member of an approving
Rust team serves as one of the maintainers of a target, or has any legal or
employment requirement (explicit or implicit) that might affect their
decisions regarding a target, they must recuse themselves from any approval
decisions regarding the target's tier status, though they may otherwise
participate in discussions.

This requirement does not prevent part or all of this policy from being
cited in an explicit contract or work agreement (e.g. to implement or
maintain support for a target). This requirement exists to ensure that a
developer or team responsible for reviewing and approving a target does not
face any legal threats or obligations that would prevent them from freely
exercising their judgment in such approval, even if such judgment involves
subjective matters or goes beyond the letter of these requirements.

Understood.
I am not a member of a Rust team.

Tier 3 targets should attempt to implement as much of the standard libraries
as possible and appropriate (core for most targets, alloc for targets
that can support dynamic memory allocation, std for targets with an
operating system or equivalent layer of system-provided functionality), but
may leave some code unimplemented (either unavailable or stubbed out as
appropriate), whether because the target makes it impossible to implement or
challenging to implement. The authors of pull requests are not obligated to
avoid calling any portions of the standard library on the basis of a tier 3
target not implementing those portions.

Understood.
std is supported.

The target must provide documentation for the Rust community explaining how
to build for the target, using cross-compilation if possible. If the target
supports running binaries, or running tests (even if they do not pass), the
documentation must explain how to run such binaries or tests for the target,
using emulation if possible or dedicated hardware if necessary.

Building is described in the derived target doc.

Tier 3 targets must not impose burden on the authors of pull requests, or
other developers in the community, to maintain the target. In particular,
do not post comments (automated or manual) on a PR that derail or suggest a
block on the PR based on a tier 3 target. Do not send automated messages or
notifications (via any medium, including via @) to a PR author or others
involved with a PR regarding a tier 3 target, unless they have opted into
such messages.

Backlinks such as those generated by the issue/PR tracker when linking to
an issue or PR are not considered a violation of this policy, within
reason. However, such messages (even on a separate repository) must not
generate notifications to anyone involved with a PR who has not requested
such notifications.

Understood.

Patches adding or updating tier 3 targets must not break any existing tier 2
or tier 1 target, and must not knowingly break another tier 3 target without
approval of either the compiler team or the maintainers of the other tier 3
target.

In particular, this may come up when working on closely related targets,
such as variations of the same architecture with different features. Avoid
introducing unconditional uses of features that another variation of the
target may not have; use conditional compilation or runtime detection, as
appropriate, to let each target run code supported by that target.

These targets are not fully ABI compatible with arm64e code.

#73628

rustbot · 2023-09-04T08:18:32Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jackh726 (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

@rustbot author: the review is finished, PR author should check the comments and take action accordingly
@rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

rustbot · 2023-09-04T08:18:34Z

These commits modify compiler targets.
(See the Target Tier Policy.)

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

Urgau

Could you address the requirements of the target tier policy in the PR description (Tier 3 in your case). As well as adding your target in the src/doc/rustc/src/platform-support.md page.

Example from another PR can be found here.

taiki-e · 2023-09-04T08:50:09Z

compiler/rustc_codegen_ssa/src/target_features.rs

+    // FEAT_PAUTH
+    ("pauth", None),


We intentionally split pauth into paca and pacg (#93782). why not use them?

Also, this adds stable target feature, but I'm not sure if adding a new target feature without a period of unstable is acceptable.

taiki-e · 2023-09-04T08:54:45Z

compiler/rustc_codegen_llvm/src/intrinsic.rs

@@ -212,6 +212,25 @@ impl<'ll, 'tcx> IntrinsicCallMethods<'tcx> for Builder<'_, 'll, 'tcx> {
                    ],
                )
            }
+
+            sym::ptr_auth_asia | sym::ptr_auth_asib | sym::ptr_auth_asda | sym::ptr_auth_asdb => {
+                if !self.sess().target.options.features.contains("+pauth") {


Using contains here is not robust and may introduce unexpected bug in the future (#114153).

Could you please clarify your point?
What is the best way to check that features exist?
On that PR, they were looking for the too small pattern, weren't they?

We can probably do the same thing that #114332 did for the c target feature. (i.e., add symbols to compiler/rustc_span/src/symbol.rs and then check to see if sess.unstable_target_features contains them.)

bjorn3 · 2023-09-04T13:43:37Z

compiler/rustc_codegen_llvm/src/intrinsic.rs

@@ -212,6 +212,27 @@ impl<'ll, 'tcx> IntrinsicCallMethods<'tcx> for Builder<'_, 'll, 'tcx> {
                    ],
                )
            }
+
+            sym::ptr_auth_asia | sym::ptr_auth_asib | sym::ptr_auth_asda | sym::ptr_auth_asdb => {


Do we actually need user facing intrinsics for this? I did expect the compiler to insert calles where necessary and if user code needs to explicitly use the pointer authentication instructions for whatever reason, it can use inline asm.

I think we might face issues, and we will have to call it directly. But presently, I have removed it. It seems asm will be complicated for this.

bjorn3 · 2023-09-04T13:51:50Z

I think we shouldn't add a tier 2 target for this until it actually is ABI compatible with arm64e code. Currently passing a rust function pointer to C code and calling it would crash due to the missing authentication tag in the pointer. Maybe make it a tier 3 target for now and have a big warning in the docs for this?

arttet · 2023-09-04T14:28:49Z

Agree. Now it is a tier 3.

jackh726 · 2023-11-19T23:12:42Z

So sorry about the wait here.

@bors r+

bors · 2023-11-19T23:12:45Z

📌 Commit a787208 has been approved by jackh726

It is now in the queue for this repository.

BlackHoleFox · 2023-11-19T23:20:32Z

compiler/rustc_target/src/spec/targets/arm64e_apple_ios.rs

+            max_atomic_width: Some(128),
+            forces_embed_bitcode: true,
+            frame_pointer: FramePointer::NonLeaf,
+            bitcode_llvm_cmdline: "-triple\0\


While its not a Git conflict, all of the legacy bitcode stuff was removed from the other targets last night in #117364. I can open a follow-up PR to remove it here as well if you don't want to do it since the timing is kinda awkward.

If you could open a followup PR, that would be awesome :) I'd rather not have @arttet wait on another round of review (i.e. me)

Will do. I'll watch for this one to merge then followup.

Add arm64e-apple-ios & arm64e-apple-darwin targets This introduces * `arm64e-apple-ios` * `arm64e-apple-darwin` Rust targets for support `arm64e` architecture on `iOS` and `Darwin`. So, this is a first approach for integrating to the Rust compiler. ## Tier 3 Target Policy > * A tier 3 target must have a designated developer or developers (the "target maintainers") on record to be CCed when issues arise regarding the target. (The mechanism to track and CC such developers may evolve over time.) I will be the target maintainer. > * Targets must use naming consistent with any existing targets; for instance, a target for the same CPU or OS as an existing Rust target should use the same name for that CPU or OS. Targets should normally use the same names and naming conventions as used elsewhere in the broader ecosystem beyond Rust (such as in other toolchains), unless they have a very good reason to diverge. Changing the name of a target can be highly disruptive, especially once the target reaches a higher tier, so getting the name right is important even for a tier 3 target. Target names should not introduce undue confusion or ambiguity unless absolutely necessary to maintain ecosystem compatibility. For example, if the name of the target makes people extremely likely to form incorrect beliefs about what it targets, the name should be changed or augmented to disambiguate it. If possible, use only letters, numbers, dashes and underscores for the name. Periods (.) are known to cause issues in Cargo. The target names `arm64e-apple-ios`, `arm64e-apple-darwin` were derived from `aarch64-apple-ios`, `aarch64-apple-darwin`. In this [ticket,](rust-lang#73628) people discussed the best suitable names for these targets. > In some cases, the arm64e arch might be "different". For example: > * `thread_set_state` might fail with (os/kern) protection failure if we try to call it from arm64 process to arm64e process. > * The returning value of dlsym is PAC signed on arm64e, while left untouched on arm64 > * Some function like pthread_create_from_mach_thread requires a PAC signed function pointer on arm64e, which is not required on arm64. So, I have chosen them because there are similar triplets in LLVM. I think there are no more suitable names for these targets. > * Tier 3 targets may have unusual requirements to build or use, but must not create legal issues or impose onerous legal terms for the Rust project or for Rust developers or users. The target must not introduce license incompatibilities. Anything added to the Rust repository must be under the standard Rust license (MIT OR Apache-2.0). The target must not cause the Rust tools or libraries built for any other host (even when supporting cross-compilation to the target) to depend on any new dependency less permissive than the Rust licensing policy. This applies whether the dependency is a Rust crate that would require adding new license exceptions (as specified by the tidy tool in the rust-lang/rust repository), or whether the dependency is a native library or binary. In other words, the introduction of the target must not cause a user installing or running a version of Rust or the Rust tools to be subject to any new license requirements. Compiling, linking, and emitting functional binaries, libraries, or other code for the target (whether hosted on the target itself or cross-compiling from another target) must not depend on proprietary (non-FOSS) libraries. Host tools built for the target itself may depend on the ordinary runtime libraries supplied by the platform and commonly used by other applications built for the target, but those libraries must not be required for code generation for the target; cross-compilation to the target must not require such libraries at all. For instance, rustc built for the target may depend on a common proprietary C runtime library or console output library, but must not depend on a proprietary code generation library or code optimization library. Rust's license permits such combinations, but the Rust project has no interest in maintaining such combinations within the scope of Rust itself, even at tier 3. "onerous" here is an intentionally subjective term. At a minimum, "onerous" legal/licensing terms include but are not limited to: non-disclosure requirements, non-compete requirements, contributor license agreements (CLAs) or equivalent, "non-commercial"/"research-only"/etc terms, requirements conditional on the employer or employment of any particular Rust developers, revocable terms, any requirements that create liability for the Rust project or its developers or users, or any requirements that adversely affect the livelihood or prospects of the Rust project or its developers or users. No dependencies were added to Rust. > * Neither this policy nor any decisions made regarding targets shall create any binding agreement or estoppel by any party. If any member of an approving Rust team serves as one of the maintainers of a target, or has any legal or employment requirement (explicit or implicit) that might affect their decisions regarding a target, they must recuse themselves from any approval decisions regarding the target's tier status, though they may otherwise participate in discussions. > * This requirement does not prevent part or all of this policy from being cited in an explicit contract or work agreement (e.g. to implement or maintain support for a target). This requirement exists to ensure that a developer or team responsible for reviewing and approving a target does not face any legal threats or obligations that would prevent them from freely exercising their judgment in such approval, even if such judgment involves subjective matters or goes beyond the letter of these requirements. Understood. I am not a member of a Rust team. > * Tier 3 targets should attempt to implement as much of the standard libraries as possible and appropriate (core for most targets, alloc for targets that can support dynamic memory allocation, std for targets with an operating system or equivalent layer of system-provided functionality), but may leave some code unimplemented (either unavailable or stubbed out as appropriate), whether because the target makes it impossible to implement or challenging to implement. The authors of pull requests are not obligated to avoid calling any portions of the standard library on the basis of a tier 3 target not implementing those portions. Understood. `std` is supported. > * The target must provide documentation for the Rust community explaining how to build for the target, using cross-compilation if possible. If the target supports running binaries, or running tests (even if they do not pass), the documentation must explain how to run such binaries or tests for the target, using emulation if possible or dedicated hardware if necessary. Building is described in the derived target doc. > * Tier 3 targets must not impose burden on the authors of pull requests, or other developers in the community, to maintain the target. In particular, do not post comments (automated or manual) on a PR that derail or suggest a block on the PR based on a tier 3 target. Do not send automated messages or notifications (via any medium, including via `@)` to a PR author or others involved with a PR regarding a tier 3 target, unless they have opted into such messages. > * Backlinks such as those generated by the issue/PR tracker when linking to an issue or PR are not considered a violation of this policy, within reason. However, such messages (even on a separate repository) must not generate notifications to anyone involved with a PR who has not requested such notifications. Understood. > * Patches adding or updating tier 3 targets must not break any existing tier 2 or tier 1 target, and must not knowingly break another tier 3 target without approval of either the compiler team or the maintainers of the other tier 3 target. > * In particular, this may come up when working on closely related targets, such as variations of the same architecture with different features. Avoid introducing unconditional uses of features that another variation of the target may not have; use conditional compilation or runtime detection, as appropriate, to let each target run code supported by that target. These targets are not fully ABI compatible with arm64e code. rust-lang#73628

…mpiler-errors Rollup of 8 pull requests Successful merges: - rust-lang#115526 (Add arm64e-apple-ios & arm64e-apple-darwin targets) - rust-lang#115691 (Add `$message_type` field to distinguish json diagnostic outputs) - rust-lang#117828 (Avoid iterating over hashmaps in astconv) - rust-lang#117832 (interpret: simplify handling of shifts by no longer trying to handle signed and unsigned shift amounts in the same branch) - rust-lang#117891 (Recover `dyn` and `impl` after `for<...>`) - rust-lang#117957 (if available use a Child's pidfd for kill/wait) - rust-lang#117994 (Ignore but do not assume region obligations from unifying headers in negative coherence) - rust-lang#118068 (subtree update cg_gcc 2023/11/17) r? `@ghost` `@rustbot` modify labels: rollup

bors · 2023-11-20T03:11:21Z

⌛ Testing commit a787208 with merge 19079cf...

bors · 2023-11-20T05:28:23Z

☀️ Test successful - checks-actions
Approved by: jackh726
Pushing 19079cf to master...

bors · 2023-11-20T05:28:23Z

☀️ Test successful - checks-actions
Approved by: jackh726
Pushing 19079cf to master...

rust-timer · 2023-11-20T06:49:59Z

Finished benchmarking commit (19079cf): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.8%	[-3.8%, -3.8%]	1
All ❌✅ (primary)	-	-	0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	4.3%	[4.2%, 4.3%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.2%	[0.2%, 0.2%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Bootstrap: 678.667s -> 677.224s (-0.21%)
Artifact size: 313.77 MiB -> 313.73 MiB (-0.01%)

Pkgsrc changes: * Adapt checksums and patches. Upstream chnages: Version 1.76.0 (2024-02-08) ========================== Language -------- - [Document Rust ABI compatibility between various types] (rust-lang/rust#115476) - [Also: guarantee that char and u32 are ABI-compatible] (rust-lang/rust#118032) - [Warn against ambiguous wide pointer comparisons] (rust-lang/rust#117758) Compiler -------- - [Lint pinned `#[must_use]` pointers (in particular, `Box<T>` where `T` is `#[must_use]`) in `unused_must_use`.] (rust-lang/rust#118054) - [Soundness fix: fix computing the offset of an unsized field in a packed struct] (rust-lang/rust#118540) - [Soundness fix: fix dynamic size/align computation logic for packed types with dyn Trait tail] (rust-lang/rust#118538) - [Add `$message_type` field to distinguish json diagnostic outputs] (rust-lang/rust#115691) - [Enable Rust to use the EHCont security feature of Windows] (rust-lang/rust#118013) - [Add tier 3 {x86_64,i686}-win7-windows-msvc targets] (rust-lang/rust#118150) - [Add tier 3 aarch64-apple-watchos target] (rust-lang/rust#119074) - [Add tier 3 arm64e-apple-ios & arm64e-apple-darwin targets] (rust-lang/rust#115526) Refer to Rust's [platform support page][platform-support-doc] for more information on Rust's tiered platform support. Libraries --------- - [Add a column number to `dbg!()`] (rust-lang/rust#114962) - [Add `std::hash::{DefaultHasher, RandomState}` exports] (rust-lang/rust#115694) - [Fix rounding issue with exponents in fmt] (rust-lang/rust#116301) - [Add T: ?Sized to `RwLockReadGuard` and `RwLockWriteGuard`'s Debug impls.] (rust-lang/rust#117138) - [Windows: Allow `File::create` to work on hidden files] (rust-lang/rust#116438) Stabilized APIs --------------- - [`Arc::unwrap_or_clone`] (https://doc.rust-lang.org/stable/std/sync/struct.Arc.html#method.unwrap_or_clone) - [`Rc::unwrap_or_clone`] (https://doc.rust-lang.org/stable/std/rc/struct.Rc.html#method.unwrap_or_clone) - [`Result::inspect`] (https://doc.rust-lang.org/stable/std/result/enum.Result.html#method.inspect) - [`Result::inspect_err`] (https://doc.rust-lang.org/stable/std/result/enum.Result.html#method.inspect_err) - [`Option::inspect`] (https://doc.rust-lang.org/stable/std/option/enum.Option.html#method.inspect) - [`type_name_of_val`] (https://doc.rust-lang.org/stable/std/any/fn.type_name_of_val.html) - [`std::hash::{DefaultHasher, RandomState}`] (https://doc.rust-lang.org/stable/std/hash/index.html#structs) These were previously available only through `std::collections::hash_map`. - [`ptr::{from_ref, from_mut}`] (https://doc.rust-lang.org/stable/std/ptr/fn.from_ref.html) - [`ptr::addr_eq`](https://doc.rust-lang.org/stable/std/ptr/fn.addr_eq.html) Cargo ----- See [Cargo release notes] (https://github.com/rust-lang/cargo/blob/master/CHANGELOG.md#cargo-176-2024-02-08). Rustdoc ------- - [Don't merge cfg and doc(cfg) attributes for re-exports] (rust-lang/rust#113091) - [rustdoc: allow resizing the sidebar / hiding the top bar] (rust-lang/rust#115660) - [rustdoc-search: add support for traits and associated types] (rust-lang/rust#116085) - [rustdoc: Add highlighting for comments in items declaration] (rust-lang/rust#117869) Compatibility Notes ------------------- - [Add allow-by-default lint for unit bindings] (rust-lang/rust#112380) This is expected to be upgraded to a warning by default in a future Rust release. Some macros emit bindings with type `()` with user-provided spans, which means that this lint will warn for user code. - [Remove x86_64-sun-solaris target.] (rust-lang/rust#118091) - [Remove asmjs-unknown-emscripten target] (rust-lang/rust#117338) - [Report errors in jobserver inherited through environment variables] (rust-lang/rust#113730) This [may warn](rust-lang/rust#120515) on benign problems too. - [Update the minimum external LLVM to 16.] (rust-lang/rust#117947) - [Improve `print_tts`](rust-lang/rust#114571) This change can break some naive manual parsing of token trees in proc macro code which expect a particular structure after `.to_string()`, rather than just arbitrary Rust code. - [Make `IMPLIED_BOUNDS_ENTAILMENT` into a hard error from a lint] (rust-lang/rust#117984) - [Vec's allocation behavior was changed when collecting some iterators] (rust-lang/rust#110353) Allocation behavior is currently not specified, nevertheless changes can be surprising. See [`impl FromIterator for Vec`] (https://doc.rust-lang.org/nightly/std/vec/struct.Vec.html#impl-FromIterator%3CT%3E-for-Vec%3CT%3E) for more details. - [Properly reject `default` on free const items] (rust-lang/rust#117818)

bitxeno · 2024-02-22T06:27:31Z

Can also add support for tvOS arm64e?

arttet · 2024-02-26T12:23:12Z

Can also add support for tvOS arm64e?

Yes, I can. Could you please create another issue for it?

bitxeno · 2024-02-27T03:17:34Z

Can also add support for tvOS arm64e?

Yes, I can. Could you please create another issue for it?

@arttet I have created the issue #121663. Thank you for your work!

rustbot assigned jackh726 Sep 4, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 4, 2023

This comment has been minimized.

Sign in to view

arttet force-pushed the master branch from 8972d11 to 8079c21 Compare September 4, 2023 08:25

This comment has been minimized.

Sign in to view

Urgau reviewed Sep 4, 2023

View reviewed changes

taiki-e reviewed Sep 4, 2023

View reviewed changes

arttet force-pushed the master branch from 8079c21 to 0d27c5e Compare September 4, 2023 11:02

rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Sep 4, 2023

arttet force-pushed the master branch 2 times, most recently from a1ed82e to 0d27c5e Compare September 4, 2023 13:39

bjorn3 reviewed Sep 4, 2023

View reviewed changes

arttet force-pushed the master branch from 0d27c5e to c5ead2b Compare September 4, 2023 14:29

arttet requested review from Urgau, bjorn3 and taiki-e September 4, 2023 15:13

arttet changed the title ~~Add arm64e-apple-ios target and Pointer Authentication feature~~ Add arm64e-apple-ios and arm64e-apple-darwin targets and Pointer Authentication feature Sep 5, 2023

arttet force-pushed the master branch from 1ec831e to 670adbf Compare September 5, 2023 07:50

arttet changed the title ~~Add arm64e-apple-ios and arm64e-apple-darwin targets and Pointer Authentication feature~~ Add arm64e-apple-ios & arm64e-apple-darwin targets and Pointer Authentication feature Sep 5, 2023

arttet force-pushed the master branch from 670adbf to 9babc17 Compare September 5, 2023 08:07

arttet closed this Sep 5, 2023

arttet force-pushed the master branch from 9babc17 to 8cfaf70 Compare September 5, 2023 08:21

arttet reopened this Sep 5, 2023

This comment has been minimized.

Sign in to view

arttet force-pushed the master branch from 3515bad to 3c50995 Compare November 15, 2023 09:48

This comment has been minimized.

Sign in to view

arttet added 2 commits November 15, 2023 14:55

Add arm64e-apple-ios target

f5e3492

Add arm64e-apple-darwin target

a787208

arttet force-pushed the master branch from 3c50995 to a787208 Compare November 15, 2023 10:56

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 19, 2023

BlackHoleFox reviewed Nov 19, 2023

View reviewed changes

compiler-errors mentioned this pull request Nov 20, 2023

Rollup of 8 pull requests #118078

Closed

bors added merged-by-bors This PR was explicitly merged by bors. labels Nov 20, 2023

bors merged commit 19079cf into rust-lang:master Nov 20, 2023
12 checks passed

rustbot added this to the 1.76.0 milestone Nov 20, 2023

arttet mentioned this pull request Nov 20, 2023

Add Pointer Authentication intrinsics #118104

Closed

glandium mentioned this pull request Jan 26, 2024

Support for ARMv8.3+ targets #73628

Open

bitxeno mentioned this pull request Feb 27, 2024

Support for tvOS arm64e target #121663

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add arm64e-apple-ios & arm64e-apple-darwin targets #115526

Add arm64e-apple-ios & arm64e-apple-darwin targets #115526

arttet commented Sep 4, 2023 •

edited

rustbot commented Sep 4, 2023

rustbot commented Sep 4, 2023

This comment has been minimized.

This comment has been minimized.

Urgau left a comment

taiki-e Sep 4, 2023

taiki-e Sep 4, 2023 •

edited

arttet Sep 4, 2023

taiki-e Sep 4, 2023 •

edited

arttet Sep 4, 2023

bjorn3 Sep 4, 2023

arttet Sep 4, 2023 •

edited

bjorn3 commented Sep 4, 2023 •

edited

arttet commented Sep 4, 2023

This comment has been minimized.

This comment has been minimized.

jackh726 commented Nov 19, 2023

bors commented Nov 19, 2023

BlackHoleFox Nov 19, 2023

jackh726 Nov 19, 2023

BlackHoleFox Nov 20, 2023

bors commented Nov 20, 2023

bors commented Nov 20, 2023

bors commented Nov 20, 2023

rust-timer commented Nov 20, 2023

bitxeno commented Feb 22, 2024

arttet commented Feb 26, 2024

bitxeno commented Feb 27, 2024 •

edited

Add arm64e-apple-ios & arm64e-apple-darwin targets #115526

Add arm64e-apple-ios & arm64e-apple-darwin targets #115526

Conversation

arttet commented Sep 4, 2023 • edited

Tier 3 Target Policy

rustbot commented Sep 4, 2023

rustbot commented Sep 4, 2023

This comment has been minimized.

This comment has been minimized.

Urgau left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

taiki-e Sep 4, 2023 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

taiki-e Sep 4, 2023 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

arttet Sep 4, 2023 • edited

Choose a reason for hiding this comment

bjorn3 commented Sep 4, 2023 • edited

arttet commented Sep 4, 2023

This comment has been minimized.

This comment has been minimized.

jackh726 commented Nov 19, 2023

bors commented Nov 19, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bors commented Nov 20, 2023

bors commented Nov 20, 2023

bors commented Nov 20, 2023

rust-timer commented Nov 20, 2023

Overall result: no relevant changes - no action needed

bitxeno commented Feb 22, 2024

arttet commented Feb 26, 2024

bitxeno commented Feb 27, 2024 • edited

arttet commented Sep 4, 2023 •

edited

taiki-e Sep 4, 2023 •

edited

taiki-e Sep 4, 2023 •

edited

arttet Sep 4, 2023 •

edited

bjorn3 commented Sep 4, 2023 •

edited

bitxeno commented Feb 27, 2024 •

edited