Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose core::error::request_value in std #114973

Merged
merged 1 commit into from Aug 20, 2023

Conversation

shepmaster
Copy link
Member

I think this was simply forgotten in #113464.

/cc @waynr

r? @Amanieu

I think this was simply forgotten in rust-lang#113464.
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 18, 2023
@waynr
Copy link
Contributor

waynr commented Aug 18, 2023

D'oh! You're right, I didn't put it there because there were no tests exercising its import from std. Thanks for catching that!

@Amanieu
Copy link
Member

Amanieu commented Aug 19, 2023

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 19, 2023

📌 Commit 74942da has been approved by Amanieu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 19, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 19, 2023
…anieu

Expose core::error::request_value in std

I think this was simply forgotten in rust-lang#113464.

/cc `@waynr`

r? `@Amanieu`
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 19, 2023
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#114605 (Increase clarity about Hash - Eq consistency in HashMap and HashSet docs)
 - rust-lang#114934 (instantiate response: no unnecessary new universe)
 - rust-lang#114950 (Inline strlen_rt in CStr::from_ptr)
 - rust-lang#114973 (Expose core::error::request_value in std)
 - rust-lang#114983 (Usage zero as language id for `FormatMessageW()`)
 - rust-lang#114991 (remove redundant var rebindings)
 - rust-lang#114992 (const-eval: ensure we never const-execute a function marked rustc_do_not_const_check)
 - rust-lang#115001 (clippy::perf stuff)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit cbcdf75 into rust-lang:master Aug 20, 2023
11 checks passed
@rustbot rustbot added this to the 1.73.0 milestone Aug 20, 2023
@shepmaster shepmaster deleted the std-provide-value branch August 23, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants