Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Identity lang item #103985

Closed
wants to merge 4 commits into from
Closed

Add Identity lang item #103985

wants to merge 4 commits into from

Conversation

GuillaumeGomez
Copy link
Member

This is another approach for #97974 suggested by @oli-obk.

The plan with this is then to add the TyAlias variant into the rustc_type_ir TyKind enum.

cc @compiler-errors

r? @oli-obk

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 4, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@GuillaumeGomez
Copy link
Member Author

I added the missing "explanation" for the ignored code block in the documentation.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jackh726
Copy link
Member

jackh726 commented Nov 5, 2022

Wait...why?

@oli-obk
Copy link
Contributor

oli-obk commented Nov 5, 2022

Wait...why?

🤣 this is missing like 112% of the context. The linked PR is a huge task it seems and I wanted @GuillaumeGomez to check if the problem is that we don't normalize in enough places or whether it's just the linked PR missing a normalization for the new type alias variant wherever we normalize projections. If this pr passes, then the linked PR should be trivial instead of adding normalization to a billion places. If this PR fails, then we can build tests that fail on master by doing the same thing as what this PR does just without a lang item and contained to a single test

@GuillaumeGomez
Copy link
Member Author

Everything falls apart as soon as we run outside of bootstrap because it doesn't seem to be able to find the Identity lang item from what I can see.

oli-obk
oli-obk requested changes Nov 14, 2022
View reviewed changes
library/core/src/lib.rs Outdated Show resolved Hide resolved
compiler/rustc_hir_analysis/src/astconv/mod.rs Outdated Show resolved Hide resolved
compiler/rustc_hir_analysis/src/astconv/mod.rs Outdated Show resolved Hide resolved
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@GuillaumeGomez GuillaumeGomez mentioned this pull request Nov 15, 2022
Closed
@bors
Copy link
Contributor

bors commented Nov 24, 2022

☔ The latest upstream changes (presumably #104321) made this pull request unmergeable. Please resolve the merge conflicts.

@clarfonthey clarfonthey mentioned this pull request Dec 7, 2022
Closed
@oli-obk oli-obk added S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 13, 2022
@GuillaumeGomez GuillaumeGomez force-pushed the ty-alias-handling branch 2 times, most recently from f51abc6 to f51255f Compare January 12, 2023 13:32
@rust-log-analyzer

This comment has been minimized.

Sign in to view
This was referenced Jan 13, 2023
Closed
Merged
@GuillaumeGomez GuillaumeGomez mentioned this pull request Jan 24, 2023
Open
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 9, 2023
@bors
Auto merge of rust-lang#106938 - GuillaumeGomez:normalize-projection-…
c40919b 
…field-ty, r=oli-obk

Add missing normalization for union fields types

Overshadows rust-lang#106808.
From the experiment rust-lang#103985.

In short, it allows to use projections as a type for union's fields.

cc `@compiler-errors`
r? `@oli-obk`
RalfJung pushed a commit to RalfJung/miri that referenced this pull request Feb 11, 2023
@bors
Auto merge of #106938 - GuillaumeGomez:normalize-projection-field-ty,…
680fff0 
… r=oli-obk

Add missing normalization for union fields types

Overshadows rust-lang/rust#106808.
From the experiment rust-lang/rust#103985.

In short, it allows to use projections as a type for union's fields.

cc `@compiler-errors`
r? `@oli-obk`
@bors
Copy link
Contributor

bors commented Mar 14, 2023

☔ The latest upstream changes (presumably #104833) made this pull request unmergeable. Please resolve the merge conflicts.

@fmease
Copy link
Member

fmease commented Nov 15, 2023 •
edited

Superseded by #108860 if I understand correctly. Closing as completed. Feel free to reopen if you disagree.

@fmease fmease closed this Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oli-obk oli-obk oli-obk requested changes

Assignees

@oli-obk oli-obk

Labels
S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@GuillaumeGomez @rust-log-analyzer @jackh726 @oli-obk @bors @fmease @rustbot