Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolve: Some cleanup, asserts and tests for lifetime ribs #102884

Merged
merged 3 commits into from Oct 15, 2022
Merged

resolve: Some cleanup, asserts and tests for lifetime ribs #102884

merged 3 commits into from Oct 15, 2022

Conversation

petrochenkov
Copy link
Contributor

Follow up to #98279 and friends.
r? @cjgillot

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Oct 10, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 10, 2022
cjgillot
cjgillot reviewed Oct 11, 2022
View reviewed changes
Copy link
Contributor

@cjgillot cjgillot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It took me some time to convince myself of the panics. Could you add a comment each time?

compiler/rustc_resolve/src/late.rs Show resolved Hide resolved
@petrochenkov
Copy link
Contributor Author

Could you add a comment each time?

Well, the comment would be "I couldn't construct an example" in half of the cases.
If some of these panics is encountered in the wild, it will be easy to remove it and add the corresponding test case to unusual-rib-combinations.rs, not a big deal.

cjgillot
cjgillot reviewed Oct 11, 2022
View reviewed changes
compiler/rustc_resolve/src/late.rs Show resolved Hide resolved
compiler/rustc_resolve/src/late.rs Show resolved Hide resolved
compiler/rustc_resolve/src/late.rs Show resolved Hide resolved
compiler/rustc_resolve/src/late.rs Show resolved Hide resolved
@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 12, 2022
@petrochenkov
Copy link
Contributor Author

Updated.
@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 13, 2022
@cjgillot
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Oct 13, 2022

📌 Commit f634106 has been approved by cjgillot

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 13, 2022
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Oct 15, 2022
@Dylan-DPC
Rollup merge of rust-lang#102884 - petrochenkov:liferib, r=cjgillot
5d29ef5 
resolve: Some cleanup, asserts and tests for lifetime ribs

Follow up to rust-lang#98279 and friends.
r? `@cjgillot`
This was referenced Oct 15, 2022
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 15, 2022
@bors
Auto merge of rust-lang#103083 - Dylan-DPC:rollup-97cvwdv, r=Dylan-DPC
c93ef33 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#102773 (Use semaphores for thread parking on Apple platforms)
 - rust-lang#102884 (resolve: Some cleanup, asserts and tests for lifetime ribs)
 - rust-lang#102954 (Add missing checks for `doc(cfg_hide(...))`)
 - rust-lang#102998 (Drop temporaries created in a condition, even if it's a let chain)
 - rust-lang#103003 (Fix `suggest_floating_point_literal` ICE)
 - rust-lang#103041 (Update cargo)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 39ff2a6 into rust-lang:master Oct 15, 2022
@rustbot rustbot added this to the 1.66.0 milestone Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjgillot cjgillot cjgillot left review comments

Assignees

@cjgillot cjgillot

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.66.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@petrochenkov @cjgillot @bors @rust-highfive @rustbot