Return multiple resolutions from def_path_res
#9800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @dswij (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Alexendoo
force-pushed
the
def_path_res_multiple
branch
from
3a25169
to
1e1ac2b
Compare
|
@bors r+ |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
This was referenced Nov 19, 2022
|
Huh I thought this was already merged 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
def_path_resto return all the resolutions matching the path rather than the first one (with a namespace hint that covered some cases). This would fix any issues that come up with multiple versions of the same crate being present as they all have the same crate nameIt also adds resolution of
impl _ {}items for local items, and removes struct field resolution as it didn't seem to be used anywhereI tested it on a local crate and it worked for the multiple crate issue, but I couldn't come up with a test that worked well with
// aux-build, maybe// aux-crateafter rust-lang/rust#103266 could work but I'm not sure on that eitherchangelog: [
disallowed_methods], [disallowed_types], [disallowed_macros]: fix path resolution with multiple versions of the same cratechangelog: [
disallowed_methods]: Resolve methods inimpls in the current crate