Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't lint path statements in no_effect #12798

Merged
merged 1 commit into from
May 14, 2024

Conversation

Alexendoo
Copy link
Member

The rustc lint path_statements covers this case

Fixes #11547

changelog: none

@rustbot
Copy link
Collaborator

rustbot commented May 14, 2024

r? @y21

rustbot has assigned @y21.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label May 14, 2024
@y21
Copy link
Member

y21 commented May 14, 2024

Makes sense, thanks! @bors r+

@bors
Copy link
Collaborator

bors commented May 14, 2024

📌 Commit 9d790d6 has been approved by y21

It is now in the queue for this repository.

@y21
Copy link
Member

y21 commented May 14, 2024

Btw. do we want this to have a changelog or did we stop doing that for small changes like that?

@bors
Copy link
Collaborator

bors commented May 14, 2024

⌛ Testing commit 9d790d6 with merge c58b6e6...

@bors
Copy link
Collaborator

bors commented May 14, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: y21
Pushing c58b6e6 to master...

@bors bors merged commit c58b6e6 into rust-lang:master May 14, 2024
5 checks passed
@Alexendoo Alexendoo deleted the no-effect-path-statements branch May 14, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

no_effect creates duplicates reports with rustc's path_statements lints
4 participants