Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint direct priority conflicts in [workspace.lints] #12730

Merged
merged 1 commit into from May 12, 2024

Conversation

Alexendoo
Copy link
Member

Partially addresses #12729

This still doesn't do any workspace resolution stuff, so it will not catch any virtual workspaces or conflicts from inherited definitions. But while we're parsing the Cargo.toml we might as well check the workspace definitions if we find them

changelog: none

@rustbot
Copy link
Collaborator

rustbot commented Apr 28, 2024

r? @xFrednet

rustbot has assigned @xFrednet.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Apr 28, 2024
@xFrednet
Copy link
Member

Roses are red,
Violets are blue,
LGTM,
thanks to you!

=^.^=

@bors
Copy link
Collaborator

bors commented May 12, 2024

📌 Commit fa8f4b8 has been approved by xFrednet

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented May 12, 2024

⌛ Testing commit fa8f4b8 with merge 2b34abc...

@bors
Copy link
Collaborator

bors commented May 12, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: xFrednet
Pushing 2b34abc to master...

@bors bors merged commit 2b34abc into rust-lang:master May 12, 2024
5 checks passed
@Alexendoo Alexendoo deleted the lint-groups-workspace-priority branch May 13, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants