Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix almost_swapped: Ignore external macros #10502

Merged
merged 3 commits into from Mar 17, 2023

Conversation

blyxyas
Copy link
Member

@blyxyas blyxyas commented Mar 14, 2023

Fixes #10421 ; Related to #10499 (Fixing points 1 and 3 from #10421)
changelog: [almost_swapped]: Add a check to ignore external macros

@rustbot
Copy link
Collaborator

rustbot commented Mar 14, 2023

r? @Manishearth

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Mar 14, 2023
@blyxyas blyxyas changed the title Ignore external macros fix almost_swapped: Ignore external macros Mar 14, 2023
@blyxyas
Copy link
Member Author

blyxyas commented Mar 14, 2023

As giraffate also managed #10499
r? giraffate

@rustbot rustbot assigned giraffate and unassigned Manishearth Mar 14, 2023
Copy link
Contributor

@giraffate giraffate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the tests be added? This PR is helpful for it: #9467

tests/ui/swap.fixed Outdated Show resolved Hide resolved
tests/ui/swap.fixed Outdated Show resolved Hide resolved
@giraffate
Copy link
Contributor

@bors r+

Thanks!

@bors
Copy link
Collaborator

bors commented Mar 17, 2023

📌 Commit 9546517 has been approved by giraffate

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Mar 17, 2023

⌛ Testing commit 9546517 with merge 5c4040e...

@bors
Copy link
Collaborator

bors commented Mar 17, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: giraffate
Pushing 5c4040e to master...

1 similar comment
@bors
Copy link
Collaborator

bors commented Mar 17, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: giraffate
Pushing 5c4040e to master...

@bors bors merged commit 5c4040e into rust-lang:master Mar 17, 2023
4 checks passed
soenkehahn added a commit to ordinals/ord that referenced this pull request Apr 22, 2023
Should be reverted once rust-lang/rust-clippy#10502
is released in a stable `clippy`.
@blyxyas blyxyas deleted the fix-almost_swapped branch October 5, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

almost_swapped false positive a=a; a=a (in clap::Parser derive)
5 participants