Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update changelog before release. #2828

Merged
merged 1 commit into from May 2, 2024
Merged

Conversation

emilio
Copy link
Contributor

@emilio emilio commented May 2, 2024

No description provided.

@emilio
Copy link
Contributor Author

emilio commented May 2, 2024

@pvdrz I'm a bit on the fence on whether #2787 should be considered a breaking change or not. On one hand, it can make code that previously compiled (but failed unit tests) fail to build. On the other, those are broken bindings. Do you have a strong feeling either way?

@emilio emilio added this pull request to the merge queue May 2, 2024
Merged via the queue into rust-lang:main with commit 770abd9 May 2, 2024
33 checks passed
@emilio emilio deleted the changelog branch May 2, 2024 11:49
@pvdrz
Copy link
Contributor

pvdrz commented May 2, 2024

@emilio I'd say it is a breaking change anyway. Even if the bindings wouldn't compile on the host, someone could be taking snapshots of their bindings to avoid breaking changes themselves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants