Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Try to fix macOS runner #2819

Merged
merged 1 commit into from Apr 27, 2024
Merged

ci: Try to fix macOS runner #2819

merged 1 commit into from Apr 27, 2024

Conversation

emilio
Copy link
Contributor

@emilio emilio commented Apr 26, 2024

Now seems to run on arm64 out of the blue...

@emilio emilio force-pushed the macos-ci branch 5 times, most recently from 835cd0a to ccc9183 Compare April 26, 2024 21:10
@pvdrz
Copy link
Contributor

pvdrz commented Apr 26, 2024

It seems we're both trying to fix it: #2820 🤣

i believe this happens because llvm was built with a different xcode version or something. However, I think we're just being affected by this: actions/runner#3256.

I also considered installing LLVM 9 on apple's arm but it seems the only prebuilt version can be installed via macports.

I think there's not much we can do regarding LLVM 9 on macos to be honest, specially if apple decides to drop x86 support eventually

@emilio
Copy link
Contributor Author

emilio commented Apr 26, 2024

I think there's not much we can do regarding LLVM 9 on macos to be honest, specially if apple decides to drop x86 support eventually

Yeah, that's why I approached this by trying to test in a new-ish llvm version... I think part of the issue is that somehow quote and co are using cc as a linker, rather than the LLVM we just downloaded...

@emilio
Copy link
Contributor Author

emilio commented Apr 26, 2024

But even with that fixed it fails so nvm...

@emilio emilio force-pushed the macos-ci branch 4 times, most recently from c8b7673 to 523ab85 Compare April 26, 2024 22:16
@leighmcculloch
Copy link

leighmcculloch commented Apr 27, 2024

Now seems to run on arm64 out of the blue...

According to this post by GitHub in January the macos-14 runner is exclusively arm64 and macos-latest was slated to update to 14 in April+:

This definitely landed in a way that was surprising though.

@emilio
Copy link
Contributor Author

emilio commented Apr 27, 2024

@pvdrz apparently macos-latest was macos-12, not macos-13, so downgrading to that fixes CI.

@emilio emilio enabled auto-merge April 27, 2024 19:23
@emilio emilio added this pull request to the merge queue Apr 27, 2024
Merged via the queue into main with commit 79e970d Apr 27, 2024
33 checks passed
@emilio emilio deleted the macos-ci branch April 27, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants