Commits on Feb 24, 2024

1. exclude packed attr for types that contain aligned types when possible …

   This patch aims to work around a limitation of rustc in which it will
   not compile types with a `packed` attr that contain types with an
   `align(N)` attr. If the `packed` attr on the outer/parent type is
   redundant, and can be removed without changing the type's layout, then
   this patch will remove that attr so that the type can be compiled under
   rustc. If the type's `packed` attr cannot be removed without changing
   the layout, then it will be left alone.
   
   Handling this correctly requires a change to when bindgen determines
   whether a type requires an `align` attr. Currently, this happens during
   the code generation phase. However, we cannot in general assume anything
   about the order in which code is generated for types, and in particular
   codegen may occur for a parent type before codegen for all child types
   contained in that parent. However, in order to strip the `packed` attr
   in cases where we want to do so, we already need to know about the
   alignment of all children.
   
   In order to make that possible, this patch moves the logic to check if a
   type requires an explicit `align` attr earlier. This now happens before
   codegen starts for the first type, so we can use information about the
   alignment of all child types to determine whether to place a `packed`
   attr on any given type.

   

   bertschingert committed Feb 24, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for c764e0c
   • Browse repository at this point

   Copy the full SHA

   c764e0c View commit details

   Browse the repository at this point in the history